Skip to content

Comments

feat: Trace api calls#32779

Merged
ggazzo merged 37 commits intodevelopfrom
meteor3/tracing
Oct 19, 2024
Merged

feat: Trace api calls#32779
ggazzo merged 37 commits intodevelopfrom
meteor3/tracing

Conversation

@rodrigok
Copy link
Member

@rodrigok rodrigok commented Jul 12, 2024 •
edited by ggazzo
Loading

closes #22335

  • Microservices support
  • Fix BaseRaw on MS
  • EnvVar to enable it
  • Error handling

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/ARCH-1300

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 12, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c0d4135

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the meteor-3.0.0 branch 5 times, most recently from 912bd7e to 7987a93 Compare July 16, 2024 20:35
@rodrigok rodrigok force-pushed the meteor3/tracing branch 2 times, most recently from c0c3484 to ba30ca1 Compare July 18, 2024 22:09
@ggazzo ggazzo force-pushed the meteor-3.0.0 branch 6 times, most recently from 2ac0404 to 35298bd Compare July 29, 2024 19:49
@ggazzo ggazzo force-pushed the meteor-3.0.0 branch 4 times, most recently from 0ce440a to c4135a6 Compare August 20, 2024 17:04
@ggazzo ggazzo force-pushed the meteor-3.0.0 branch 4 times, most recently from b8aa17f to 56a7cad Compare September 11, 2024 22:22
@ggazzo ggazzo force-pushed the meteor-3.0.0 branch 3 times, most recently from ea36162 to d3bb302 Compare September 13, 2024 20:11
@sampaiodiego sampaiodiego marked this pull request as ready for review October 18, 2024 17:03
@sampaiodiego sampaiodiego requested review from a team as code owners October 18, 2024 17:03
sampaiodiego
sampaiodiego previously approved these changes Oct 18, 2024
View reviewed changes
KevLehman
KevLehman previously approved these changes Oct 18, 2024
View reviewed changes
@rodrigok
Copy link
Member Author

rodrigok commented Oct 18, 2024

I can't approve, but LGMT

MarcosSpessatto
MarcosSpessatto suggested changes Oct 18, 2024
View reviewed changes
@sampaiodiego sampaiodiego dismissed stale reviews from KevLehman and themself via 1339608 October 18, 2024 21:48
@rodrigok rodrigok added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
KevLehman
KevLehman previously approved these changes Oct 18, 2024
View reviewed changes
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Oct 19, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 19, 2024
@ggazzo ggazzo dismissed stale reviews from MarcosSpessatto and KevLehman via c0d4135 October 19, 2024 00:52
@ggazzo ggazzo merged commit 429d000 into develop Oct 19, 2024
@ggazzo ggazzo deleted the meteor3/tracing branch October 19, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego left review comments

@ggazzo ggazzo ggazzo approved these changes

@KevLehman KevLehman KevLehman left review comments

+1 more reviewer

@MarcosSpessatto MarcosSpessatto MarcosSpessatto left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Milestone

7.0

Development

Successfully merging this pull request may close these issues.

6 participants

@rodrigok @ggazzo @sampaiodiego @KevLehman @MarcosSpessatto @ricardogarim