Skip to content

fix: deactivate federated internal users permanently with the external user#32809

Merged
kodiakhq[bot] merged 29 commits intodevelopfrom
CORE-519
Aug 20, 2024
Merged

fix: deactivate federated internal users permanently with the external user#32809
kodiakhq[bot] merged 29 commits intodevelopfrom
CORE-519

Conversation

@debdutdeb
Copy link
Copy Markdown
Member

@debdutdeb debdutdeb commented Jul 17, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-616

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: e98904f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.40%. Comparing base (5d657ee) to head (e98904f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32809      +/-   ##
===========================================
- Coverage    59.40%   59.40%   -0.01%     
===========================================
  Files         2543     2543              
  Lines        63180    63183       +3     
  Branches     14219    14223       +4     
===========================================
  Hits         37533    37533              
- Misses       22931    22934       +3     
  Partials      2716     2716              
Flag Coverage Δ
unit 76.02% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb debdutdeb changed the title chore: prevent deletion of federated users and rooms fix: deactivate federated internal users permanently with the external user Jul 21, 2024
@debdutdeb debdutdeb added this to the 6.11 milestone Jul 21, 2024
@casalsgh casalsgh modified the milestones: 6.11, 6.12 Jul 22, 2024
@debdutdeb debdutdeb marked this pull request as ready for review August 8, 2024 13:46
@debdutdeb debdutdeb requested a review from a team as a code owner August 8, 2024 13:46
@debdutdeb debdutdeb added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2024
@kodiakhq kodiakhq bot merged commit f20be47 into develop Aug 20, 2024
@kodiakhq kodiakhq bot deleted the CORE-519 branch August 20, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants