Skip to content

fix: imported fixes#32815

Merged
ggazzo merged 5 commits intodevelopfrom
chore/message-template
Jul 18, 2024
Merged

fix: imported fixes#32815
ggazzo merged 5 commits intodevelopfrom
chore/message-template

Conversation

@ggazzo
Copy link
Copy Markdown
Member

@ggazzo ggazzo commented Jul 17, 2024

SB-529

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: e2c45c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.51%. Comparing base (c3e9c61) to head (e2c45c5).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32815      +/-   ##
===========================================
- Coverage    55.54%   55.51%   -0.03%     
===========================================
  Files         2634     2629       -5     
  Lines        57215    57162      -53     
  Branches     11849    11841       -8     
===========================================
- Hits         31780    31734      -46     
+ Misses       22750    22742       -8     
- Partials      2685     2686       +1     
Flag Coverage Δ
e2e 54.26% <100.00%> (-0.02%) ⬇️
unit 72.09% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/message-template branch from 6e6dda2 to 81bde9f Compare July 17, 2024 14:42
@ggazzo ggazzo changed the title chore: remove messageType.render fix: imported fixes Jul 18, 2024
@ggazzo ggazzo added this to the 6.11 milestone Jul 18, 2024
@ggazzo ggazzo marked this pull request as ready for review July 18, 2024 18:06
@ggazzo ggazzo requested a review from a team as a code owner July 18, 2024 18:06
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2024
@ggazzo ggazzo merged commit e827c58 into develop Jul 18, 2024
@ggazzo ggazzo deleted the chore/message-template branch July 18, 2024 20:36
@ggazzo
Copy link
Copy Markdown
Member Author

ggazzo commented Jul 18, 2024

/patch

dionisio-bot bot pushed a commit that referenced this pull request Jul 18, 2024
@dionisio-bot dionisio-bot bot mentioned this pull request Jul 18, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 18, 2024

Pull request #32836 added to Project: "Patch 6.10.1"

sampaiodiego pushed a commit that referenced this pull request Jul 23, 2024
@sampaiodiego
Copy link
Copy Markdown
Member

/backport 6.9.4

dionisio-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@dionisio-bot dionisio-bot bot mentioned this pull request Jul 23, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 23, 2024

Pull request #32872 added to Project: "Patch 6.9.4"

@sampaiodiego
Copy link
Copy Markdown
Member

/backport 6.8.4

dionisio-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@dionisio-bot dionisio-bot bot mentioned this pull request Jul 23, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 23, 2024

Pull request #32882 added to Project: "Patch 6.8.4"

@sampaiodiego
Copy link
Copy Markdown
Member

/backport 6.7.6

dionisio-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@dionisio-bot dionisio-bot bot mentioned this pull request Jul 23, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 23, 2024

Pull request #32883 added to Project: "Patch 6.7.6"

@sampaiodiego
Copy link
Copy Markdown
Member

/backport 6.6.11

dionisio-bot bot pushed a commit that referenced this pull request Jul 23, 2024
@dionisio-bot dionisio-bot bot mentioned this pull request Jul 23, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 23, 2024

Pull request #32884 added to Project: "Patch 6.6.11"

sampaiodiego pushed a commit that referenced this pull request Jul 24, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
sampaiodiego pushed a commit that referenced this pull request Jul 24, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
debdutdeb pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants