regression: default to already stored value not value from code

[debdutdeb]

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-585

Cache was getting updated with value in code if a property in code other than value changed from what was stored.

Steps to test or reproduce

Further comments

Test cases:

1. Set cache immediately as OVERWRITE_SETTING or Setting_id environment variables are set
2. Don't set cache at all if value did not change from what was stored vs what is in environment (ignoring code)

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9c63b6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.66%. Comparing base (5ecdaff) to head (9c63b6a).

Additional details and impacted files

@@                Coverage Diff                 @@
##           release-6.11.0   #32870      +/-   ##
==================================================
- Coverage           55.67%   55.66%   -0.01%     
==================================================
  Files                2636     2636              
  Lines               57428    57429       +1     
  Branches            11902    11903       +1     
==================================================
- Hits                31971    31969       -2     
+ Misses              22767    22739      -28     
- Partials             2690     2721      +31     

Flag	Coverage Δ
e2e	54.32% <ø> (-0.02%)	⬇️
unit	72.30% <50.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.