Skip to content

Comments

feat: VoIP freeswitch UI start call actions#33008

Merged
tassoevan merged 20 commits intofeat/freeswitch-6-12from
feat/voip-freeswitch-ui-start-call
Sep 26, 2024
Merged

feat: VoIP freeswitch UI start call actions#33008
tassoevan merged 20 commits intofeat/freeswitch-6-12from
feat/voip-freeswitch-ui-start-call

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Aug 7, 2024

Proposed changes (including videos or screenshots)

This PR adds triggers for enabling/disable voice calling, start 1:1 a voice calls and start calls from the dialer.

Enabled/disable voice calling

Screenshot 2024-08-15 at 14 10 45

Start call menu in room toolbox (direct messages)

Screenshot 2024-08-15 at 14 01 34

Start call from user card

Screenshot 2024-08-15 at 14 02 36

Start voice call from profile contextual bar

Screenshot 2024-08-15 at 14 03 06

Start voice call from members contextual bar

Screenshot 2024-08-15 at 14 08 38

Open dial pad (NavBarV2)

Screenshot 2024-08-22 at 11 35 17

Issue(s)

VOIP-74
VOIP-50
VOIP-84
VOIP-88
VOIP-89
VOIP-90
VOIP-96
VOIP-97

Steps to test or reproduce

  • Go to workspace settings

  • Enable VoIP for Team Collab

  • Back to home

  • Click profile picture

  • Enable voice calling

  • Go to direct message

  • Start call in the room toolbox

  • For the dial pad button it's also necessary to enabled "Enhanced navigation experience" in Feature Preview.

Further comments

ℹ️ Commits might help more easily review/navigate each of the mentioned actions.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.14.0, but it targets 6.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: a795c52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch from 10a73eb to 517586d Compare August 8, 2024 13:52
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from cd21928 to 9066fd3 Compare August 8, 2024 13:53
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch 2 times, most recently from d16a430 to 82b5eb1 Compare August 8, 2024 15:52
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from 9066fd3 to 5c0c9b1 Compare August 8, 2024 15:53
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch from 82b5eb1 to 799b10b Compare August 14, 2024 17:31
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from 5c0c9b1 to b3e17fc Compare August 14, 2024 17:32
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch from 799b10b to 66ebece Compare August 14, 2024 19:02
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from b3e17fc to a16056d Compare August 14, 2024 19:03
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch from 66ebece to 5ff0c6a Compare August 14, 2024 19:17
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from a16056d to 87059b2 Compare August 14, 2024 19:17
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch from 5ff0c6a to e4fdccf Compare August 16, 2024 15:27
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from 87059b2 to a24446b Compare August 16, 2024 17:30
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch from e4fdccf to 3e1f49f Compare August 16, 2024 18:10
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from a24446b to ab5bce6 Compare August 16, 2024 18:11
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch from 3e1f49f to f57ec36 Compare August 16, 2024 18:16
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from ab5bce6 to d05fec3 Compare August 16, 2024 18:17
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch from f57ec36 to d995e70 Compare August 20, 2024 16:16
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from d05fec3 to e54de60 Compare August 20, 2024 16:25
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-components branch 2 times, most recently from 7ef982f to 5f0512a Compare August 20, 2024 18:22
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from e54de60 to 3a14520 Compare August 20, 2024 20:05
@aleksandernsilva aleksandernsilva added this to the 6.12 milestone Aug 21, 2024
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@aleksandernsilva aleksandernsilva removed the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from f363a22 to 1093e36 Compare August 21, 2024 17:04
Base automatically changed from feat/voip-freeswitch-ui-components to feat/freeswitch-6-12 September 25, 2024 21:04
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-start-call branch from b4ff239 to 59268b8 Compare September 25, 2024 21:07
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aleksandernsilva aleksandernsilva modified the milestones: 6.13, 6.14 Sep 26, 2024
@tassoevan tassoevan merged commit 175b2b8 into feat/freeswitch-6-12 Sep 26, 2024
@tassoevan tassoevan deleted the feat/voip-freeswitch-ui-start-call branch September 26, 2024 21:38
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants