feat: VoIP freeswitch UI start call actions#33008
Merged
tassoevan merged 20 commits intofeat/freeswitch-6-12from Sep 26, 2024
Merged
feat: VoIP freeswitch UI start call actions#33008tassoevan merged 20 commits intofeat/freeswitch-6-12from
tassoevan merged 20 commits intofeat/freeswitch-6-12from
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
10a73eb to
517586d
Compare
cd21928 to
9066fd3
Compare
d16a430 to
82b5eb1
Compare
9066fd3 to
5c0c9b1
Compare
82b5eb1 to
799b10b
Compare
5c0c9b1 to
b3e17fc
Compare
799b10b to
66ebece
Compare
b3e17fc to
a16056d
Compare
66ebece to
5ff0c6a
Compare
a16056d to
87059b2
Compare
5ff0c6a to
e4fdccf
Compare
87059b2 to
a24446b
Compare
e4fdccf to
3e1f49f
Compare
a24446b to
ab5bce6
Compare
3e1f49f to
f57ec36
Compare
ab5bce6 to
d05fec3
Compare
f57ec36 to
d995e70
Compare
d05fec3 to
e54de60
Compare
7ef982f to
5f0512a
Compare
e54de60 to
3a14520
Compare
f363a22 to
1093e36
Compare
Base automatically changed from
feat/voip-freeswitch-ui-components
to
feat/freeswitch-6-12
September 25, 2024 21:04
b4ff239 to
59268b8
Compare
tassoevan
approved these changes
Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR adds triggers for enabling/disable voice calling, start 1:1 a voice calls and start calls from the dialer.
Enabled/disable voice calling
Start call menu in room toolbox (direct messages)
Start call from user card
Start voice call from profile contextual bar
Start voice call from members contextual bar
Open dial pad (NavBarV2)
Issue(s)
VOIP-74
VOIP-50
VOIP-84
VOIP-88
VOIP-89
VOIP-90
VOIP-96
VOIP-97
Steps to test or reproduce
Go to workspace settings
Enable VoIP for Team Collab
Back to home
Click profile picture
Enable voice calling
Go to direct message
Start call in the room toolbox
For the dial pad button it's also necessary to enabled "Enhanced navigation experience" in Feature Preview.
Further comments
ℹ️ Commits might help more easily review/navigate each of the mentioned actions.