Skip to content

chore: Visitors' messages are being counted as agents' responses in livechat metrics#33022

Merged
ggazzo merged 5 commits intodevelopfrom
chore/agents-responses-metrics
Aug 20, 2024
Merged

chore: Visitors' messages are being counted as agents' responses in livechat metrics#33022
ggazzo merged 5 commits intodevelopfrom
chore/agents-responses-metrics

Conversation

@matheusbsilva137
Copy link
Copy Markdown
Contributor

@matheusbsilva137 matheusbsilva137 commented Aug 9, 2024

Proposed changes (including videos or screenshots)

  • Stop considering visitors' messages when building livechat metrics. Only agents' messages should be considered responses
  • Removed getAnalyticsUpdateQueryByRoomId model method since we don't need this shortcut anymore (analyticsData is only defined for agents)

Visitor's messages are never first responses for a room, neither a subsequent response -- so we shouldn't try to update metrics related to these events.

Issue(s)

Steps to test or reproduce

Further comments

Introduced by #32961
Blocking #32846

CORE-645

@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner August 9, 2024 16:59
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Aug 9, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: c85b2da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ricardogarim
ricardogarim previously approved these changes Aug 9, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.40%. Comparing base (f20be47) to head (c85b2da).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33022      +/-   ##
===========================================
- Coverage    59.40%   59.40%   -0.01%     
===========================================
  Files         2543     2543              
  Lines        63183    63182       -1     
  Branches     14220    14220              
===========================================
- Hits         37533    37532       -1     
  Misses       22934    22934              
  Partials      2716     2716              
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardogarim
ricardogarim previously approved these changes Aug 13, 2024
@KevLehman KevLehman added this to the 6.12 milestone Aug 20, 2024
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 20, 2024
@ggazzo ggazzo merged commit 51f35b4 into develop Aug 20, 2024
@ggazzo ggazzo deleted the chore/agents-responses-metrics branch August 20, 2024 16:43
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants