Skip to content

Comments

fix: Missing retention's ignoreThreads param for old channels#33028

Merged
ggazzo merged 3 commits intorelease-7.0.0from
fix/ignoreThreadsDefaultValue
Aug 17, 2024
Merged

fix: Missing retention's ignoreThreads param for old channels#33028
ggazzo merged 3 commits intorelease-7.0.0from
fix/ignoreThreadsDefaultValue

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Aug 12, 2024

Proposed changes (including videos or screenshots)

Introduced here: #32485

While introducing this new possibility in retention policy overriding feature, old channels were not being affected, because it was missing the ignoreThreads parameter. So we decide to add a migration to add the missing parameter in all channels with retention policy override.

Issue(s)

Closes #32794

Steps to test or reproduce

Further comments

CORE-613

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Aug 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: 3d82e07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.39%. Comparing base (8c447cf) to head (3d82e07).
Report is 7 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33028   +/-   ##
==============================================
  Coverage          59.39%   59.39%           
==============================================
  Files               2541     2541           
  Lines              63175    63175           
  Branches           14220    14220           
==============================================
  Hits               37525    37525           
  Misses             22935    22935           
  Partials            2715     2715           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.12 milestone Aug 12, 2024
@dougfabris dougfabris marked this pull request as ready for review August 12, 2024 21:16
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed previously, we shouldn't use the setting value as the default value since it would affect the current behaviour. Even though the current behaviour is "wrong", we would be breaking user's expectations and this could be harmful.

We should proceed just with the migration for the next major version.

@dougfabris dougfabris force-pushed the fix/ignoreThreadsDefaultValue branch from 85c8118 to 994e04d Compare August 13, 2024 18:47
@dougfabris dougfabris requested review from a team as code owners August 13, 2024 18:47
@dougfabris dougfabris changed the base branch from develop to release-7.0.0 August 13, 2024 18:47
@dougfabris dougfabris modified the milestones: 6.12, 7.0 Aug 13, 2024
@dougfabris dougfabris requested a review from gabriellsh August 13, 2024 18:49
@dougfabris dougfabris changed the title fix: Uses ignore threads global value when overriding old channels retention policy fix: Missing retention's ignoreThreads param for old channels Aug 13, 2024
@dougfabris dougfabris removed request for a team August 13, 2024 18:57
@ggazzo ggazzo force-pushed the release-7.0.0 branch 2 times, most recently from 30f6f98 to 8c447cf Compare August 16, 2024 13:09
@ggazzo ggazzo force-pushed the fix/ignoreThreadsDefaultValue branch from 916d9c9 to 7f51287 Compare August 16, 2024 17:27
ggazzo
ggazzo previously approved these changes Aug 16, 2024
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Threads are not getting pruned

6 participants