fix: Missing retention's ignoreThreads param for old channels#33028
fix: Missing retention's ignoreThreads param for old channels#33028ggazzo merged 3 commits intorelease-7.0.0from
ignoreThreads param for old channels#33028Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3d82e07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33028 +/- ##
==============================================
Coverage 59.39% 59.39%
==============================================
Files 2541 2541
Lines 63175 63175
Branches 14220 14220
==============================================
Hits 37525 37525
Misses 22935 22935
Partials 2715 2715
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
left a comment
There was a problem hiding this comment.
As we discussed previously, we shouldn't use the setting value as the default value since it would affect the current behaviour. Even though the current behaviour is "wrong", we would be breaking user's expectations and this could be harmful.
We should proceed just with the migration for the next major version.
85c8118 to
994e04d
Compare
ignoreThreads param for old channels
30f6f98 to
8c447cf
Compare
916d9c9 to
7f51287
Compare
Proposed changes (including videos or screenshots)
Introduced here: #32485
While introducing this new possibility in retention policy overriding feature, old channels were not being affected, because it was missing the
ignoreThreadsparameter. So we decide to add a migration to add the missing parameter in all channels with retention policy override.Issue(s)
Closes #32794
Steps to test or reproduce
Further comments
CORE-613