Skip to content

Comments

fix: Local avatars prioritized over external avatar provider and remove remnant references on client of Accounts_AvatarExternalProviderUrl#33314

Merged
kodiakhq[bot] merged 1 commit intorelease-6.12.2from
backport-6.12.2-33296
Sep 25, 2024
Merged

fix: Local avatars prioritized over external avatar provider and remove remnant references on client of Accounts_AvatarExternalProviderUrl#33314
kodiakhq[bot] merged 1 commit intorelease-6.12.2from
backport-6.12.2-33296

Conversation

@dionisio-bot
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Sep 18, 2024

Backport of #33296

…ve remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296)

Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
@dionisio-bot dionisio-bot bot requested review from a team as code owners September 18, 2024 15:30
@dionisio-bot dionisio-bot bot requested a review from tassoevan September 18, 2024 15:30
@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 5cdb1f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot
Copy link
Contributor Author

dionisio-bot bot commented Sep 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.71%. Comparing base (ac00085) to head (5cdb1f5).
Report is 2 commits behind head on release-6.12.2.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-6.12.2   #33314   +/-   ##
===============================================
  Coverage           58.71%   58.71%           
===============================================
  Files                2682     2682           
  Lines               65011    65000   -11     
  Branches            14603    14599    -4     
===============================================
- Hits                38169    38167    -2     
+ Misses              24366    24357    -9     
  Partials             2476     2476           
Flag Coverage Δ
unit 77.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@scuciatto scuciatto added stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge labels Sep 19, 2024
@kodiakhq kodiakhq bot merged commit a71d0f0 into release-6.12.2 Sep 25, 2024
@kodiakhq kodiakhq bot deleted the backport-6.12.2-33296 branch September 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants