Skip to content

Comments

chore!: remove livechat:addAgent and livechat:addManager method#33372

Merged
ggazzo merged 1 commit intorelease-7.0.0from
chore/remove-livechat-addAgent-addManager-method
Oct 1, 2024
Merged

chore!: remove livechat:addAgent and livechat:addManager method#33372
ggazzo merged 1 commit intorelease-7.0.0from
chore/remove-livechat-addAgent-addManager-method

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Sep 26, 2024

Proposed changes (including videos or screenshots)

This PR removes deprecated livechat:addAgent and livechat:addManager method.

Issue(s)

Steps to test or reproduce

Further comments

CORE-363
CORE-362

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 5ad2f96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@abhinavkrin abhinavkrin changed the base branch from develop to release-7.0.0 September 26, 2024 10:12
@abhinavkrin abhinavkrin marked this pull request as ready for review September 26, 2024 10:15
@abhinavkrin abhinavkrin requested a review from a team as a code owner September 26, 2024 10:15
@abhinavkrin abhinavkrin force-pushed the chore/remove-livechat-addAgent-addManager-method branch from 886bf10 to cb49a35 Compare September 26, 2024 10:25
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33372/
on branch gh-pages at 2024-10-01 01:12 UTC

@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@b1f6559). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33372   +/-   ##
================================================
  Coverage                 ?   75.32%           
================================================
  Files                    ?      383           
  Lines                    ?    19383           
  Branches                 ?     4980           
================================================
  Hits                     ?    14601           
  Misses                   ?     4212           
  Partials                 ?      570           
Flag Coverage Δ
unit 75.32% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo requested review from a team as code owners September 27, 2024 18:05
@abhinavkrin abhinavkrin force-pushed the chore/remove-livechat-addAgent-addManager-method branch from cb49a35 to a5a0f4d Compare September 27, 2024 19:05
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@ggazzo ggazzo force-pushed the chore/remove-livechat-addAgent-addManager-method branch from a5a0f4d to 5ad2f96 Compare October 1, 2024 01:06
@ggazzo ggazzo added this to the 7.0 milestone Oct 1, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 1, 2024
@ggazzo ggazzo merged commit c9a263c into release-7.0.0 Oct 1, 2024
@ggazzo ggazzo deleted the chore/remove-livechat-addAgent-addManager-method branch October 1, 2024 01:07
ggazzo pushed a commit that referenced this pull request Oct 8, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
abhinavkrin added a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
This was referenced Oct 20, 2024
abhinavkrin added a commit that referenced this pull request Oct 25, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants