fix: Encrypted push notification missing message.content#33377
Merged
kodiakhq[bot] merged 9 commits intodevelopfrom Oct 16, 2024
Merged
fix: Encrypted push notification missing message.content#33377kodiakhq[bot] merged 9 commits intodevelopfrom
kodiakhq[bot] merged 9 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: d5a37ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33377 +/- ##
===========================================
+ Coverage 58.43% 59.43% +1.00%
===========================================
Files 2746 2611 -135
Lines 66285 64301 -1984
Branches 15001 14472 -529
===========================================
- Hits 38732 38217 -515
+ Misses 24731 23321 -1410
+ Partials 2822 2763 -59
Flags with carried forward coverage won't be shown. Click here to find out more. |
10 tasks
hugocostadev
approved these changes
Sep 26, 2024
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
ggazzo
pushed a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
ggazzo
pushed a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
We moved
msgtomessage.contenton #32316This PR sends content on push notification payload, so mobile can decrypt it.
Issue(s)
Steps to test or reproduce
Further comments
Found it while working on RocketChat/Rocket.Chat.ReactNative#5865