Skip to content

Comments

fix: Encrypted push notification missing message.content#33377

Merged
kodiakhq[bot] merged 9 commits intodevelopfrom
fix.encrypted-push-content
Oct 16, 2024
Merged

fix: Encrypted push notification missing message.content#33377
kodiakhq[bot] merged 9 commits intodevelopfrom
fix.encrypted-push-content

Conversation

@diegolmello
Copy link
Member

@diegolmello diegolmello commented Sep 26, 2024

Proposed changes (including videos or screenshots)

We moved msg to message.content on #32316
This PR sends content on push notification payload, so mobile can decrypt it.

Issue(s)

Steps to test or reproduce

Further comments

Found it while working on RocketChat/Rocket.Chat.ReactNative#5865

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: d5a37ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33377/
on branch gh-pages at 2024-10-16 16:44 UTC

@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.43%. Comparing base (f810929) to head (d5a37ff).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33377      +/-   ##
===========================================
+ Coverage    58.43%   59.43%   +1.00%     
===========================================
  Files         2746     2611     -135     
  Lines        66285    64301    -1984     
  Branches     15001    14472     -529     
===========================================
- Hits         38732    38217     -515     
+ Misses       24731    23321    -1410     
+ Partials      2822     2763      -59     
Flag Coverage Δ
unit 74.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev added this to the 6.14 milestone Sep 26, 2024
@hugocostadev hugocostadev added the stat: QA assured Means it has been tested and approved by a company insider label Sep 26, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 26, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 26, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@kodiakhq kodiakhq bot merged commit df7f669 into develop Oct 16, 2024
@kodiakhq kodiakhq bot deleted the fix.encrypted-push-content branch October 16, 2024 17:55
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
This was referenced Oct 20, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants