Skip to content

Comments

feat!: Airgapped composer restriction and warning banner#33382

Merged
gabriellsh merged 9 commits intofeat/airgapped-restrictionsfrom
airgapped/composer-restriction
Oct 18, 2024
Merged

feat!: Airgapped composer restriction and warning banner#33382
gabriellsh merged 9 commits intofeat/airgapped-restrictionsfrom
airgapped/composer-restriction

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Sep 26, 2024

Proposed changes (including videos or screenshots)

Issue(s)

AIR-3
AIR-9

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Sep 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 87c6474

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33382/
on branch gh-pages at 2024-10-18 13:09 UTC

@codecov
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.94%. Comparing base (5ebc821) to head (870ff3b).

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           feat/airgapped-restrictions   #33382   +/-   ##
============================================================
  Coverage                        74.94%   74.94%           
============================================================
  Files                              474      474           
  Lines                            20840    20840           
  Branches                          5303     5303           
============================================================
  Hits                             15618    15618           
  Misses                            4602     4602           
  Partials                           620      620           

@gabriellsh gabriellsh changed the base branch from develop to release-7.0.0 October 2, 2024 23:46
@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
@ggazzo ggazzo force-pushed the release-7.0.0 branch 8 times, most recently from bfefe41 to 204272c Compare October 15, 2024 00:45
@gabriellsh gabriellsh force-pushed the airgapped/composer-restriction branch 2 times, most recently from 3ffa75a to 309dbef Compare October 16, 2024 00:41
@gabriellsh gabriellsh changed the base branch from release-7.0.0 to feat/airgapped-restrictions October 16, 2024 00:42
@gabriellsh gabriellsh force-pushed the feat/airgapped-restrictions branch from 0819868 to e859eea Compare October 17, 2024 14:13
@gabriellsh gabriellsh force-pushed the airgapped/composer-restriction branch from 309dbef to 68560b1 Compare October 17, 2024 14:39
@gabriellsh gabriellsh marked this pull request as ready for review October 17, 2024 14:40
@gabriellsh gabriellsh requested a review from a team as a code owner October 17, 2024 14:40
@gabriellsh gabriellsh force-pushed the airgapped/composer-restriction branch 3 times, most recently from 11a94f7 to 48b8470 Compare October 17, 2024 21:12
@ggazzo ggazzo added this to the 7.0 milestone Oct 18, 2024
@gabriellsh gabriellsh force-pushed the airgapped/composer-restriction branch from 48b8470 to 870ff3b Compare October 18, 2024 12:45
@milton-rucks milton-rucks added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@gabriellsh gabriellsh force-pushed the airgapped/composer-restriction branch from 870ff3b to 87c6474 Compare October 18, 2024 16:37
@gabriellsh gabriellsh merged commit a4527e0 into feat/airgapped-restrictions Oct 18, 2024
@gabriellsh gabriellsh deleted the airgapped/composer-restriction branch October 18, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants