chore!: remove deprecated livechat:saveTrigger and livechat:removeTrigger method

[abhinavkrin]

Proposed changes (including videos or screenshots)

Removed deprecated methods livechat:saveTrigger and livechat:removeTrigger. Moving forward use the endpoints livechat/triggers (POST) and livechat/triggers/:_id (DELETE) respectively.

Issue(s)

Steps to test or reproduce

Further comments

CORE-382
CORE-387

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 3abfe1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/ui-voip	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-11 16:21 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@e6f5a02). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-7.0.0   #33429   +/-   ##
================================================
  Coverage                 ?   75.69%           
================================================
  Files                    ?      430           
  Lines                    ?    19893           
  Branches                 ?     5078           
================================================
  Hits                     ?    15059           
  Misses                   ?     4264           
  Partials                 ?      570           

Flag	Coverage Δ
unit	75.69% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

[KevLehman]

Its maybe more work but we removed the other methods 1 by 1 and this PR removes 2 at once... should we split?

[abhinavkrin]

Its maybe more work but we removed the other methods 1 by 1 and this PR removes 2 at once... should we split?

Hey @KevLehman , Since there are lots of deprecations to be removed, I grouped the somewhat related methods into one pr. This will also reduce the time for review and merge. wdys ?

The merge-base changed after approval.