Skip to content

Comments

chore!: remove deprecated livechat:requestTranscript and livechat:discardTranscript methods#33432

Merged
ggazzo merged 2 commits intorelease-7.0.0from
chore/remove-deprecated-livechat-requestTranscript-discardTranscript
Oct 11, 2024
Merged

chore!: remove deprecated livechat:requestTranscript and livechat:discardTranscript methods#33432
ggazzo merged 2 commits intorelease-7.0.0from
chore/remove-deprecated-livechat-requestTranscript-discardTranscript

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Oct 3, 2024

Proposed changes (including videos or screenshots)

Removed deprecated methods livechat:requestTranscript and livechat:discardTranscript. Moving forward use livechat/transcript/:rid endpoint's POST and DELETE methods.

Issue(s)

Steps to test or reproduce

Further comments

CORE-379
CORE-383

@abhinavkrin abhinavkrin added this to the 7.0 milestone Oct 3, 2024
@abhinavkrin abhinavkrin requested a review from a team as a code owner October 3, 2024 17:49
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: 1890586

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-11 16:23 UTC

@codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@74b16b5). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33432   +/-   ##
================================================
  Coverage                 ?   75.66%           
================================================
  Files                    ?      430           
  Lines                    ?    19904           
  Branches                 ?     5079           
================================================
  Hits                     ?    15060           
  Misses                   ?     4273           
  Partials                 ?      571           
Flag Coverage Δ
unit 75.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin marked this pull request as draft October 3, 2024 18:42
@abhinavkrin abhinavkrin marked this pull request as ready for review October 3, 2024 19:37
@abhinavkrin abhinavkrin requested a review from a team as a code owner October 3, 2024 19:37
@ggazzo ggazzo requested review from a team as code owners October 8, 2024 17:42
@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
@ggazzo ggazzo force-pushed the chore/remove-deprecated-livechat-requestTranscript-discardTranscript branch from b2636ac to 78ac180 Compare October 9, 2024 20:16
@MarcosSpessatto MarcosSpessatto removed request for a team October 11, 2024 12:39
@ggazzo ggazzo dismissed MarcosSpessatto’s stale review October 11, 2024 15:56

The merge-base changed after approval.

@ggazzo ggazzo requested a review from a team as a code owner October 11, 2024 15:56
…chat:discardTranscript

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
…chat:discardTranscript

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@ggazzo ggazzo force-pushed the chore/remove-deprecated-livechat-requestTranscript-discardTranscript branch from 78ac180 to 1890586 Compare October 11, 2024 16:22
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 11, 2024
@ggazzo ggazzo merged commit 87e2bca into release-7.0.0 Oct 11, 2024
@ggazzo ggazzo deleted the chore/remove-deprecated-livechat-requestTranscript-discardTranscript branch October 11, 2024 16:22
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This was referenced Oct 20, 2024
abhinavkrin added a commit that referenced this pull request Oct 25, 2024
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants