chore!: remove deprecated livechat:requestTranscript and livechat:discardTranscript methods#33432
Merged
ggazzo merged 2 commits intorelease-7.0.0from Oct 11, 2024
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 1890586 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33432 +/- ##
================================================
Coverage ? 75.66%
================================================
Files ? 430
Lines ? 19904
Branches ? 5079
================================================
Hits ? 15060
Misses ? 4273
Partials ? 571
Flags with carried forward coverage won't be shown. Click here to find out more. |
d1aa5f9 to
374979f
Compare
b2636ac to
78ac180
Compare
MarcosSpessatto
previously approved these changes
Oct 11, 2024
The merge-base changed after approval.
…chat:discardTranscript Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
…chat:discardTranscript Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
78ac180 to
1890586
Compare
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 14, 2024
…cardTranscript methods (#33432)
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 14, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 15, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…cardTranscript methods (#33432)
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
added a commit
that referenced
this pull request
Oct 25, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Nov 6, 2024
…cardTranscript methods (#33432)
ggazzo
pushed a commit
that referenced
this pull request
Nov 6, 2024
…cardTranscript methods (#33432)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Removed deprecated methods
livechat:requestTranscriptandlivechat:discardTranscript. Moving forward uselivechat/transcript/:ridendpoint's POST and DELETE methods.Issue(s)
Steps to test or reproduce
Further comments
CORE-379
CORE-383