feat!: renamed voip-related settings#33434
Merged
aleksandernsilva merged 7 commits intorelease-7.0.0from Oct 15, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 056117a The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
aleksandernsilva
force-pushed
the
chore/rename-voip-settings
branch
from
2b9bd35 to
8d23ef7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33434 +/- ##
=================================================
- Coverage 74.80% 74.79% -0.01%
=================================================
Files 467 467
Lines 20643 20641 -2
Branches 5263 5262 -1
=================================================
- Hits 15442 15439 -3
Misses 4590 4590
- Partials 611 612 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
aleksandernsilva
changed the title
aleksandernsilva
changed the title
aleksandernsilva
changed the title
aleksandernsilva
force-pushed
the
chore/rename-voip-settings
branch
from
bccaf79 to
8dec359
Compare
aleksandernsilva
changed the title
aleksandernsilva
force-pushed
the
chore/rename-voip-settings
branch
from
cd20346 to
8b21926
Compare
tassoevan
previously requested changes
Oct 14, 2024
Contributor
tassoevan
left a comment
tassoevan
left a comment
There was a problem hiding this comment.
It has to be handled as a breaking change -- i.e. tagged as feat!: and heading towards release-7.0.0 branch.
dionisio-bot
bot
added
stat: ready to merge
aleksandernsilva
removed
the
stat: ready to merge
aleksandernsilva
changed the title
aleksandernsilva
force-pushed
the
chore/rename-voip-settings
branch
from
3610d02 to
31dfbfc
Compare
aleksandernsilva
force-pushed
the
chore/rename-voip-settings
branch
from
bc9c7a7 to
db01633
Compare
KevLehman
reviewed
Oct 14, 2024
ggazzo
force-pushed
the
chore/rename-voip-settings
branch
from
3a77759 to
eb85a79
Compare
tassoevan
force-pushed
the
chore/rename-voip-settings
branch
from
eb85a79 to
c2af0ff
Compare
tassoevan
previously approved these changes
Oct 15, 2024
KevLehman
approved these changes
Oct 15, 2024
tassoevan
approved these changes
Oct 15, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
* chore: renamed voip settings * i18n: expressions for voip team collab * chore: renamed omnichannel voip settings group * i18n: removed and adjusted expression * chore: changeset * chore: adjusted migration * chore: updated changeset to major
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
* chore: renamed voip settings * i18n: expressions for voip team collab * chore: renamed omnichannel voip settings group * i18n: removed and adjusted expression * chore: changeset * chore: adjusted migration * chore: updated changeset to major
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
* chore: renamed voip settings * i18n: expressions for voip team collab * chore: renamed omnichannel voip settings group * i18n: removed and adjusted expression * chore: changeset * chore: adjusted migration * chore: updated changeset to major
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
* chore: renamed voip settings * i18n: expressions for voip team collab * chore: renamed omnichannel voip settings group * i18n: removed and adjusted expression * chore: changeset * chore: adjusted migration * chore: updated changeset to major
This was referenced Oct 20, 2024
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
With the introduction of voip for team collaboration we are changes some settings to improve clarity.
Changes are as follows:
Voice channel->Omnichannel voice channel (VoIP)VoIP for TeamCollab->Team voice calls (VoIP)Issue(s)
VOIP-109
Steps to test or reproduce
Further comments