fix: Server not notifying users of E2EE key suggestions#33435
Merged
kodiakhq[bot] merged 7 commits intodevelopfrom Oct 8, 2024
Merged
fix: Server not notifying users of E2EE key suggestions#33435kodiakhq[bot] merged 7 commits intodevelopfrom
kodiakhq[bot] merged 7 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 9aaf9da The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
KevLehman
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33435 +/- ##
========================================
Coverage 58.58% 58.58%
========================================
Files 2737 2737
Lines 65679 65677 -2
Branches 14824 14824
========================================
- Hits 38479 38478 -1
+ Misses 24421 24420 -1
Partials 2779 2779
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardogarim
previously approved these changes
Oct 4, 2024
pierre-lehnen-rc
previously approved these changes
Oct 4, 2024
sampaiodiego
requested changes
Oct 8, 2024
KevLehman
dismissed stale reviews from pierre-lehnen-rc and ricardogarim
via
580ced7
sampaiodiego
approved these changes
Oct 8, 2024
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Ricardo Garim <9621276+ricardogarim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/E2EE2-74
Steps to test or reproduce
Further comments
This prevents users to know that they got a new key suggestion, forcing them to either refresh the page or send a message (which triggers a room notification because of the message counter increasing) in order to know they have a suggested E2EE key.