chore!: remove deprecated livechat:saveSurveyFeedback method#33443
Merged
ggazzo merged 1 commit intorelease-7.0.0from Oct 9, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 63d25de The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33443 +/- ##
==============================================
Coverage 75.66% 75.66%
==============================================
Files 430 430
Lines 19904 19904
Branches 5079 5079
==============================================
Hits 15060 15060
Misses 4273 4273
Partials 571 571
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
previously approved these changes
Oct 7, 2024
ggazzo
dismissed
tassoevan’s stale review
The merge-base changed after approval.
sampaiodiego
force-pushed
the
release-7.0.0
branch
2 times, most recently
from
d1aa5f9 to
374979f
Compare
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
abhinavkrin
force-pushed
the
chore/remove-deprecated-livechat-saveSurveyFeedback-method
branch
from
a0f3988 to
63d25de
Compare
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
ggazzo
deleted the
chore/remove-deprecated-livechat-saveSurveyFeedback-method
branch
abhinavkrin
added a commit
that referenced
this pull request
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 14, 2024
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 14, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 15, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
added a commit
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Removed deprecated method
livechat:saveSurveyFeedback. Moving forward use the endpointlivechat/room.survey.Issue(s)
Steps to test or reproduce
Further comments
CORE-374