Skip to content

Comments

chore!: remove deprecated method deleteMessage#33472

Merged
ggazzo merged 2 commits intorelease-7.0.0from
chore/remove-deprecated-method-deleteMessage
Oct 9, 2024
Merged

chore!: remove deprecated method deleteMessage#33472
ggazzo merged 2 commits intorelease-7.0.0from
chore/remove-deprecated-method-deleteMessage

Conversation

@abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Oct 5, 2024

Proposed changes (including videos or screenshots)

  • Removed deprecated deleteMessage method. Moving forward, use the chat.delete endpoint.
  • Modified the deleteMessage function of createDataAPI to use chat.delete endpoint instead of the deleted deleteMessage method.

Issue(s)

Steps to test or reproduce

Further comments

CORE-353

@abhinavkrin abhinavkrin added this to the 7.0 milestone Oct 5, 2024
@abhinavkrin abhinavkrin requested review from a team as code owners October 5, 2024 13:19
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2024

🦋 Changeset detected

Latest commit: 4ba3fa2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33472/
on branch gh-pages at 2024-10-09 20:14 UTC

@codecov
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.66%. Comparing base (52ca57d) to head (7022f96).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33472   +/-   ##
==============================================
  Coverage          75.66%   75.66%           
==============================================
  Files                430      430           
  Lines              19904    19904           
  Branches            5079     5079           
==============================================
  Hits               15060    15060           
  Misses              4273     4273           
  Partials             571      571           
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Oct 8, 2024
@ggazzo ggazzo dismissed tassoevan’s stale review October 8, 2024 17:42

The merge-base changed after approval.

@ggazzo ggazzo requested review from a team as code owners October 8, 2024 17:42
@tassoevan tassoevan force-pushed the chore/remove-deprecated-method-deleteMessage branch from 78dc651 to 7022f96 Compare October 9, 2024 05:49
tassoevan
tassoevan previously approved these changes Oct 9, 2024
@sampaiodiego sampaiodiego dismissed tassoevan’s stale review October 9, 2024 15:20

The merge-base changed after approval.

@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
abhinavkrin and others added 2 commits October 9, 2024 16:50
@ggazzo ggazzo force-pushed the chore/remove-deprecated-method-deleteMessage branch from 7022f96 to 4ba3fa2 Compare October 9, 2024 19:50
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 9, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 9, 2024
@ggazzo ggazzo merged commit 4bd63e7 into release-7.0.0 Oct 9, 2024
@ggazzo ggazzo deleted the chore/remove-deprecated-method-deleteMessage branch October 9, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants