Skip to content

Comments

feat: apply category reorder on Enhanced navigation#33496

Merged
ggazzo merged 2 commits intodevelopfrom
feat/category-reorder-sidebarv2
Oct 10, 2024
Merged

feat: apply category reorder on Enhanced navigation#33496
ggazzo merged 2 commits intodevelopfrom
feat/category-reorder-sidebarv2

Conversation

@juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Oct 8, 2024

SIDE-129

Proposed changes (including videos or screenshots)

Apply the category order defined on the admin setting on admin > settings > accounts > default user pref > Sidebar sections order on Enhanced navigation experience feature preview.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: f04888e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-10 20:01 UTC

@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.57%. Comparing base (34879cc) to head (f04888e).
Report is 34 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33496   +/-   ##
========================================
  Coverage    58.57%   58.57%           
========================================
  Files         2737     2737           
  Lines        65763    65761    -2     
  Branches     14826    14825    -1     
========================================
  Hits         38521    38521           
+ Misses       24463    24461    -2     
  Partials      2779     2779           
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review October 8, 2024 17:54
@juliajforesti juliajforesti requested a review from a team as a code owner October 8, 2024 17:54
@juliajforesti juliajforesti added this to the 7.0 milestone Oct 8, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 10, 2024
@ggazzo ggazzo modified the milestones: 7.0, 6.14 Oct 10, 2024
@ggazzo ggazzo merged commit 02debbe into develop Oct 10, 2024
@ggazzo ggazzo deleted the feat/category-reorder-sidebarv2 branch October 10, 2024 19:47
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants