feat: E2EE room key reset modal#33503
Merged
kodiakhq[bot] merged 29 commits intodevelopfrom Oct 18, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 502616b The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
f1a821b to
fd881cd
Compare
2c114c8 to
ac2dae4
Compare
aleksandernsilva
requested changes
Oct 11, 2024
dd6caeb to
2910905
Compare
f9923c3 to
a5903b1
Compare
KevLehman
requested changes
Oct 11, 2024
apps/meteor/client/views/room/modals/E2EEModals/ResetKeysE2EEModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/modals/E2EEModals/EnableE2EEModal.tsx
Outdated
Show resolved
Hide resolved
5bbcb1d to
a5903b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33503 +/- ##
========================================
Coverage 74.85% 74.85%
========================================
Files 470 470
Lines 20744 20744
Branches 5295 5295
========================================
Hits 15528 15528
Misses 4595 4595
Partials 621 621
Flags with carried forward coverage won't be shown. Click here to find out more. |
74c35e3 to
a5903b1
Compare
44cb522 to
a0e985d
Compare
5015408 to
2435c3b
Compare
KevLehman
reviewed
Oct 14, 2024
5435cb9 to
2872812
Compare
fix: remove duplicated toast error
454e22d to
415ddca
Compare
aleksandernsilva
approved these changes
Oct 17, 2024
KevLehman
approved these changes
Oct 17, 2024
tassoevan
approved these changes
Oct 17, 2024
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Kevin Aleman <11577696+KevLehman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
If all the members of a room lose their room E2EE keys, then the content of encrypted messages becomes undecryptable forever, and no member has the ability to send new encrypted messages in the room, even after they reset their private E2EE keys.
Given the nature of E2EE, loosing the access to encrypted content when the user loses their E2E keys is something acceptable in the industry, and the most part of other players operate this way. The problem in our implementation is loosing the ability to send new encrypted messages.
To minimize the number of unnecessary room key resets, we created two flows for disabling E2EE (check designs), and one additional warning for enabling E2EE
1 - User does NOT have room key: A button to reset the room key will be exhibited inside the Disable room encryption modal
2 - User has room key: For this use case, the option to reset the room key will NOT be exhibited, and the Disable Encryption modal text is a bit different
3 - Enabling E2EE: A confirmation modal was created
Issue(s)
Steps to test or reproduce
Further comments
TODO
https://rocketchat.atlassian.net/browse/E2EE2-62