Skip to content

Comments

feat: new fields contact#33504

Merged
kodiakhq[bot] merged 13 commits intodevelopfrom
feat/new-fields-contact
Oct 11, 2024
Merged

feat: new fields contact#33504
kodiakhq[bot] merged 13 commits intodevelopfrom
feat/new-fields-contact

Conversation

@tapiarafael
Copy link
Contributor

@tapiarafael tapiarafael commented Oct 8, 2024

Proposed changes (including videos or screenshots)

Introduce createdAt and lastChat fields for Contact entity

Issue(s)

Steps to test or reproduce

Further comments

SCI-87

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.14.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: e19c19f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-11 13:11 UTC

@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.59%. Comparing base (305b591) to head (e19c19f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33504   +/-   ##
========================================
  Coverage    58.59%   58.59%           
========================================
  Files         2739     2739           
  Lines        65696    65696           
  Branches     14826    14826           
========================================
  Hits         38496    38496           
  Misses       24420    24420           
  Partials      2780     2780           
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael marked this pull request as ready for review October 9, 2024 10:54
@tapiarafael tapiarafael requested review from a team as code owners October 9, 2024 10:54
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test to cover the lastChat addition?

@tapiarafael tapiarafael requested a review from a team as a code owner October 9, 2024 13:42
@tapiarafael tapiarafael added the stat: QA assured Means it has been tested and approved by a company insider label Oct 10, 2024
@tapiarafael tapiarafael added this to the 7.0 milestone Oct 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 10, 2024
@kodiakhq kodiakhq bot merged commit 6ece177 into develop Oct 11, 2024
@kodiakhq kodiakhq bot deleted the feat/new-fields-contact branch October 11, 2024 13:11
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants