Skip to content

Comments

regression: missing permission checks on voip for team collab#33518

Merged
kodiakhq[bot] merged 8 commits intodevelopfrom
chore/voip-permissions
Oct 15, 2024
Merged

regression: missing permission checks on voip for team collab#33518
kodiakhq[bot] merged 8 commits intodevelopfrom
chore/voip-permissions

Conversation

@aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 9, 2024

Proposed changes (including videos or screenshots)

Added permissions checks on voip for team collab. This affects voice calling and extension management.

Issue(s)

VOIP-111

Steps to test or reproduce

  • Access workspace
  • Configure Workspace > "Team voice calls (VoIP)"
  • User needs to have "Manage Voip Extension" permission for assign/unassign extensions on admin users page
  • User needs to have "View VoIP extension details" permission to see contact information during calls
  • User needs to have "View User VoIP extension" permission to enable the voip UI amongst other things.

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 9, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 280d9bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33518/
on branch gh-pages at 2024-10-15 21:05 UTC

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.42%. Comparing base (31eb47f) to head (280d9bd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33518      +/-   ##
===========================================
- Coverage    58.42%   58.42%   -0.01%     
===========================================
  Files         2745     2745              
  Lines        66276    66275       -1     
  Branches     14998    14998              
===========================================
- Hits         38724    38723       -1     
  Misses       24730    24730              
  Partials      2822     2822              
Flag Coverage Δ
unit 74.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva changed the title chore: added permission check to enable voip feat: consider permission for enabling voip for team collab Oct 10, 2024
@aleksandernsilva aleksandernsilva changed the base branch from develop to refactor/users-header-content October 13, 2024 20:21
@aleksandernsilva aleksandernsilva changed the title feat: consider permission for enabling voip for team collab feat: permission checks for voip for team collab Oct 13, 2024
@aleksandernsilva aleksandernsilva changed the title feat: permission checks for voip for team collab regression: missing permission checks on voip for team collab Oct 13, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 13, 2024 22:02
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner October 13, 2024 22:02
@aleksandernsilva aleksandernsilva changed the base branch from refactor/users-header-content to develop October 14, 2024 10:11
@aleksandernsilva aleksandernsilva added this to the 6.14 milestone Oct 14, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Oct 15, 2024
MartinSchoeler
MartinSchoeler previously approved these changes Oct 15, 2024
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aleksandernsilva aleksandernsilva marked this pull request as draft October 15, 2024 14:22
@aleksandernsilva aleksandernsilva added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 15, 2024
@kodiakhq kodiakhq bot merged commit 5cc9ac5 into develop Oct 15, 2024
@kodiakhq kodiakhq bot deleted the chore/voip-permissions branch October 15, 2024 22:00
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants