fix!: Only room creator can set the E2EE room key for the first time#33520
Merged
sampaiodiego merged 3 commits intorelease-7.0.0from Oct 11, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: b619923 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33520 +/- ##
================================================
Coverage ? 75.70%
================================================
Files ? 432
Lines ? 19919
Branches ? 5084
================================================
Hits ? 15079
Misses ? 4269
Partials ? 571
Flags with carried forward coverage won't be shown. Click here to find out more. |
e6e7faf to
9196ec4
Compare
9196ec4 to
af9f94a
Compare
fa2b5a3 to
ba4ed73
Compare
MarcosSpessatto
previously approved these changes
Oct 11, 2024
Contributor
MarcosSpessatto
left a comment
There was a problem hiding this comment.
We should change this to a fix instead
The merge-base changed after approval.
ba4ed73 to
9260ef7
Compare
sampaiodiego
approved these changes
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 14, 2024
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 14, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 15, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
room.u._idis the same as the user requesting. Currently anyone invited to the room can set the roomKeyID (and the E2EE key) before the owner gets the key, which can cause race conditions and leave the room in a bad state.Issue(s)
https://rocketchat.atlassian.net/browse/E2EE2-79
Steps to test or reproduce
Further comments