Skip to content

Comments

fix: imported fixes#33583

Merged
kodiakhq[bot] merged 6 commits intodevelopfrom
imported-fixes-2024-10-15
Oct 15, 2024
Merged

fix: imported fixes#33583
kodiakhq[bot] merged 6 commits intodevelopfrom
imported-fixes-2024-10-15

Conversation

@julio-cfa
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@julio-cfa julio-cfa requested a review from a team as a code owner October 15, 2024 12:24
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: 29e1a4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@julio-cfa julio-cfa added this to the 6.14 milestone Oct 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33583/
on branch gh-pages at 2024-10-15 21:16 UTC

@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.45%. Comparing base (5cc9ac5) to head (29e1a4c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33583      +/-   ##
===========================================
+ Coverage    58.42%   58.45%   +0.02%     
===========================================
  Files         2745     2745              
  Lines        66275    66365      +90     
  Branches     14998    14938      -60     
===========================================
+ Hits         38723    38793      +70     
- Misses       24730    24765      +35     
+ Partials      2822     2807      -15     
Flag Coverage Δ
unit 74.62% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-cfa julio-cfa added the stat: QA assured Means it has been tested and approved by a company insider label Oct 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 15, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Oct 15, 2024
@julio-cfa julio-cfa added the stat: ready to merge PR tested and approved waiting for merge label Oct 15, 2024
@kodiakhq kodiakhq bot merged commit e14fa89 into develop Oct 15, 2024
@kodiakhq kodiakhq bot deleted the imported-fixes-2024-10-15 branch October 15, 2024 23:17
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
This was referenced Oct 20, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
ggazzo pushed a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants