feat: Search, create and edit contacts#33591
Merged
dougfabris merged 7 commits intofeat/single-contact-idfrom Oct 16, 2024
Merged
feat: Search, create and edit contacts#33591dougfabris merged 7 commits intofeat/single-contact-idfrom
dougfabris merged 7 commits intofeat/single-contact-idfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 03f2c92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dougfabris
force-pushed
the
feat/search-create-edit
branch
from
c0910ce to
5c221e7
Compare
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33591 +/- ##
==========================================================
- Coverage 58.35% 58.34% -0.01%
==========================================================
Files 2746 2746
Lines 66378 66370 -8
Branches 15020 15015 -5
==========================================================
- Hits 38733 38725 -8
Misses 24810 24810
Partials 2835 2835
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
force-pushed
the
feat/single-contact-id
branch
from
e549453 to
761c2a6
Compare
* feat: get contact data from the new endpoint * feat: allow multiple emails and phone numbers * chore: `ContactManagerInput` to ts * chore: add fields validations
dougfabris
force-pushed
the
feat/search-create-edit
branch
from
d93cd4a to
bc1faf5
Compare
dougfabris
force-pushed
the
feat/search-create-edit
branch
from
097b727 to
03f2c92
Compare
tapiarafael
approved these changes
Oct 16, 2024
pierre-lehnen-rc
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments