Skip to content

Comments

chore: replace fs+promisify with fs/promises#33599

Merged
ggazzo merged 1 commit intodevelopfrom
chore/use-fs-promises
Oct 16, 2024
Merged

chore: replace fs+promisify with fs/promises#33599
ggazzo merged 1 commit intodevelopfrom
chore/use-fs-promises

Conversation

@pierre-lehnen-rc
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: a4f82ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pierre-lehnen-rc pierre-lehnen-rc added this to the 6.14 milestone Oct 15, 2024
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review October 15, 2024 23:23
@github-actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33599/
on branch gh-pages at 2024-10-15 23:27 UTC

@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.43%. Comparing base (e14fa89) to head (a4f82ee).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33599   +/-   ##
========================================
  Coverage    58.43%   58.43%           
========================================
  Files         2746     2746           
  Lines        66283    66283           
  Branches     15001    15001           
========================================
  Hits         38730    38730           
  Misses       24730    24730           
  Partials      2823     2823           
Flag Coverage Δ
unit 74.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 3abc1e5 into develop Oct 16, 2024
@ggazzo ggazzo deleted the chore/use-fs-promises branch October 16, 2024 02:51
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants