Skip to content

Comments

chore!: remove query field on custom emojis listing#33650

Merged
ggazzo merged 6 commits intodevelopfrom
chore/emoji-custom-query-param
Oct 19, 2024
Merged

chore!: remove query field on custom emojis listing#33650
ggazzo merged 6 commits intodevelopfrom
chore/emoji-custom-query-param

Conversation

@ricardogarim
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: e74c1a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/rest-typings Major
@rocket.chat/meteor Major
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ricardogarim ricardogarim added this to the 7.0 milestone Oct 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33650/
on branch gh-pages at 2024-10-18 23:08 UTC

@codecov
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (509143d) to head (e74c1a5).
Report is 20 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33650      +/-   ##
===========================================
+ Coverage    74.85%   74.88%   +0.02%     
===========================================
  Files          470      473       +3     
  Lines        20744    20810      +66     
  Branches      5295     5314      +19     
===========================================
+ Hits         15528    15583      +55     
- Misses        4595     4602       +7     
- Partials       621      625       +4     
Flag Coverage Δ
unit 74.88% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review October 18, 2024 18:12
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners October 18, 2024 18:12
@MarcosSpessatto MarcosSpessatto changed the title chore: remove query field on custom emojis listing chore!: remove query field on custom emojis listing Oct 18, 2024
@MarcosSpessatto MarcosSpessatto added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Oct 18, 2024
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is a chore, the behaviour of the endpoint has slightly changes (common used fields passed through query param are now regular params)

So this could be a feat, but even if it isn't, this change requires a changeset. Can you add the changeset please, and evaluate if it is a feat or improve?

Co-authored-by: gabriellsh <40830821+gabriellsh@users.noreply.github.com>
@ggazzo ggazzo merged commit f4365b7 into develop Oct 19, 2024
@ggazzo ggazzo deleted the chore/emoji-custom-query-param branch October 19, 2024 00:54
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants