Skip to content

Comments

regression: Revert changes that restrict livechat visitors to their source type scope#33694

Merged
kodiakhq[bot] merged 1 commit intorelease-7.0.0from
regression/sci-source-type-scope-revert
Oct 22, 2024
Merged

regression: Revert changes that restrict livechat visitors to their source type scope#33694
kodiakhq[bot] merged 1 commit intorelease-7.0.0from
regression/sci-source-type-scope-revert

Conversation

@matheusbsilva137
Copy link
Contributor

@matheusbsilva137 matheusbsilva137 commented Oct 21, 2024

Proposed changes (including videos or screenshots)

This reverts #33569 (which will only be kept in the feature branch and should not be included in 7.0 without the remaining parts of the SCI feature)

Issue(s)

Steps to test or reproduce

Further comments

@matheusbsilva137 matheusbsilva137 requested review from a team as code owners October 21, 2024 17:45
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 21, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 2fccbfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33694/
on branch gh-pages at 2024-10-21 17:59 UTC

@codecov
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.97%. Comparing base (ce283bf) to head (2fccbfa).
Report is 2 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33694   +/-   ##
==============================================
  Coverage          74.97%   74.97%           
==============================================
  Files                480      480           
  Lines              21019    21019           
  Branches            5334     5334           
==============================================
  Hits               15760    15760           
  Misses              4630     4630           
  Partials             629      629           
Flag Coverage Δ
unit 74.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Oct 22, 2024
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Oct 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 22, 2024
@kodiakhq kodiakhq bot merged commit cac8e39 into release-7.0.0 Oct 22, 2024
@kodiakhq kodiakhq bot deleted the regression/sci-source-type-scope-revert branch October 22, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants