feat!: Restrict livechat visitors to their source type scope#33760
Closed
pierre-lehnen-rc wants to merge 23 commits intodevelopfrom
Closed
feat!: Restrict livechat visitors to their source type scope#33760pierre-lehnen-rc wants to merge 23 commits intodevelopfrom
pierre-lehnen-rc wants to merge 23 commits intodevelopfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: bff9207 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33760 +/- ##
========================================
Coverage 74.96% 74.96%
========================================
Files 481 481
Lines 21042 21042
Branches 5339 5339
========================================
Hits 15775 15775
Misses 4635 4635
Partials 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
suggested changes
Oct 24, 2024
pierre-lehnen-rc
force-pushed
the
feat/channel-name-visitors-2
branch
from
8ad37b9 to
a5696b2
Compare
matheusbsilva137
suggested changes
Oct 24, 2024
Comment on lines
+2
to
+5
| "@rocket.chat/meteor": minor | ||
| "@rocket.chat/apps": minor | ||
| "@rocket.chat/core-typings": minor | ||
| "@rocket.chat/model-typings": minor |
Contributor
There was a problem hiding this comment.
Suggested change
| "@rocket.chat/meteor": minor | |
| "@rocket.chat/apps": minor | |
| "@rocket.chat/core-typings": minor | |
| "@rocket.chat/model-typings": minor | |
| "@rocket.chat/meteor": major | |
| "@rocket.chat/apps": major | |
| "@rocket.chat/core-typings": minor | |
| "@rocket.chat/model-typings": minor |
Some changes should be tagged as major now, shouldn't they? Not sure about core and model typings
Contributor
Author
|
Closing in favor of https://adr.rocket.chat/0114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring PR #33569 which got reverted on 7.0;
Proposed changes (including videos or screenshots)
sourcefield toILivechatVisitortype, which stores the channel (eg API, widget, SMS, email-inbox, app) that's been used by the visitor to send messages. Each visitor can now only be linked to a single source, and each user that has already been linked to a source can't be reused in another channel.Issue(s)
Steps to test or reproduce
Further comments
SCI-88