fix: prevent loading page on reconnect#33770
Merged
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 2ec55cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33770 +/- ##
===========================================
- Coverage 75.56% 75.55% -0.01%
===========================================
Files 491 492 +1
Lines 21533 21558 +25
Branches 5368 5373 +5
===========================================
+ Hits 16271 16288 +17
- Misses 4625 4630 +5
- Partials 637 640 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
711cc9a to
5682885
Compare
5682885 to
f8e4a74
Compare
sampaiodiego
previously approved these changes
Oct 24, 2024
tassoevan
previously approved these changes
Oct 25, 2024
jeanfbrito
previously approved these changes
Oct 25, 2024
07a9739 to
0a31a88
Compare
Member
Author
jeanfbrito
previously approved these changes
Oct 25, 2024
ggazzo
added a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Merged
ggazzo
added a commit
that referenced
this pull request
Nov 6, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

https://rocketchat.atlassian.net/browse/CORE-761
Proposed changes (including videos or screenshots)
Issue(s)
ARCH-1309
Steps to test or reproduce
Further comments