regression: remove query field on settings public listing

[ricardogarim]

Proposed changes (including videos or screenshots)

Per CORE-765, this update shifts the _id query parameter directly to the root level in GET /api/v1/settings.public and removes the query attribute.

• _id can now be passed directly at the root level and supports a comma-separated list of setting IDs (e.g., _id=Site_Url or _id=Site_Url,LDAP_Enable).
• The query attribute is removed, aligning with the new structure outlined in CORE-718.
  • For continued query use, set the ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMS environment variable to true when initializing the server.

Issue(s)

• CORE-765 and CORE-764

Steps to test or reproduce

Further comments

Note to Mobile Team – Based on getServerInfo.ts#L124 and getSettings.ts#L114, it looks like _id is the only attribute needing support. If any other parameters are required, please reach out.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 92317e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/rest-typings	Major
@rocket.chat/meteor	Major
@rocket.chat/api-client	Patch
@rocket.chat/core-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/livechat	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/ui-voip	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/core-typings	Major
@rocket.chat/apps	Patch
@rocket.chat/cron	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (af361a3) to head (92317e2).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.0.0   #33787   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           

Flag	Coverage Δ
unit	74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33787/
on branch gh-pages at 2024-10-28 15:03 UTC