Skip to content

Comments

chore!: Remove old retention maxAge settings#33797

Merged
ggazzo merged 1 commit intorelease-7.0.0from
chore/removeRetentionSettings
Oct 28, 2024
Merged

chore!: Remove old retention maxAge settings#33797
ggazzo merged 1 commit intorelease-7.0.0from
chore/removeRetentionSettings

Conversation

@gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Removes "soft" migration added here: https://github.com/RocketChat/Rocket.Chat/pull/32425/files#diff-d2a5af684ab8c456c39979a1bf9497783b7929d797fafca29ea6fdadde25c8c2

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested review from a team as code owners October 25, 2024 23:47
@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: ae5fc5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 25, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@gabriellsh gabriellsh force-pushed the chore/removeRetentionSettings branch from 5ef6eed to ae5fc5d Compare October 25, 2024 23:49
@gabriellsh gabriellsh changed the title chore: Remove old retention maxAge settings chore!: Remove old retention maxAge settings Oct 25, 2024
@gabriellsh gabriellsh added this to the 7.0 milestone Oct 25, 2024
@github-actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33797/
on branch gh-pages at 2024-10-26 00:03 UTC

@codecov
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (a2da346) to head (ae5fc5d).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33797   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 8188319 into release-7.0.0 Oct 28, 2024
@ggazzo ggazzo deleted the chore/removeRetentionSettings branch October 28, 2024 12:42
gabriellsh added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants