regression: remove query field on messages listing#33801
Merged
kodiakhq[bot] merged 2 commits intorelease-7.0.0from Oct 28, 2024
Merged
regression: remove query field on messages listing#33801kodiakhq[bot] merged 2 commits intorelease-7.0.0from
kodiakhq[bot] merged 2 commits intorelease-7.0.0from
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 09bb8bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ricardogarim
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33801 +/- ##
==============================================
Coverage 74.96% 74.96%
==============================================
Files 481 481
Lines 21044 21044
Branches 5339 5339
==============================================
Hits 15776 15776
Misses 4636 4636
Partials 632 632
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
ricardogarim
force-pushed
the
chore/channels-messages-query-param
branch
from
49fef9f to
09bb8bb
Compare
ricardogarim
changed the title
MarcosSpessatto
approved these changes
Oct 28, 2024
MarcosSpessatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Per CORE-767, this update shifts the
mentions._id,starred._id, andpinnedquery parameters directly to the root level in GET/api/v1/channels.messagesand removes the query attribute.mentions._idshould now be passed asmentionIdsdirectly at the root level and supports a comma-separated list of setting IDs (e.g.,mentionIds=fooormentionIds=foo,bar).starred._idshould now be passed asstarredIdsdirectly at the root level and supports a comma-separated list of setting IDs (e.g.,starredIds=fooorstarredIds=foo,bar).pinnedshould now be passed directly at the root level as a boolean or string.ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMSenvironment variable totruewhen initializing the server.Issue(s)
Steps to test or reproduce
Further comments
Note to Mobile Team – Based on channels.ts#L112, it looks like
mentions._id,starred._id, andpinnedare the attributes needing support. If any other parameters are required, please reach out.