Skip to content

Comments

regression: remove query field on dm messages listing#33807

Merged
kodiakhq[bot] merged 6 commits intorelease-7.0.0from
chore/dm-messages-query-param
Oct 28, 2024
Merged

regression: remove query field on dm messages listing#33807
kodiakhq[bot] merged 6 commits intorelease-7.0.0from
chore/dm-messages-query-param

Conversation

@ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Oct 27, 2024

Proposed changes (including videos or screenshots)

Per CORE-770, this update shifts the mentions._id, starred._id, and pinned query parameters directly to the root level in GET /api/v1/im.messages and /api/v1/dm.messages and removes the query attribute.

  • mentions._id should now be passed as mentionIds directly at the root level and supports a comma-separated list of setting IDs (e.g., mentionIds=foo or mentionIds=foo,bar).
  • starred._id should now be passed as starredIds directly at the root level and supports a comma-separated list of setting IDs (e.g., starredIds=foo or starredIds=foo,bar).
  • pinned should now be passed directly at the root level as a boolean or string.
  • The query attribute is removed, aligning with the new structure outlined in CORE-718.
    • For continued query use, set the ALLOW_UNSAFE_QUERY_AND_FIELDS_API_PARAMS environment variable to true when initializing the server.

Steps to test or reproduce

Issue(s)

Steps to test or reproduce

Further comments

Note to Mobile Team – Based on im.ts#L68, it looks like mentions._id, starred._id, and pinned are the attributes needing support. If any other parameters are required, please reach out.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2024

🦋 Changeset detected

Latest commit: b7d46ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/rest-typings Major
@rocket.chat/meteor Major
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/livechat Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ricardogarim ricardogarim force-pushed the chore/dm-messages-query-param branch from 8018ccc to 57232fe Compare October 27, 2024 16:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33807/
on branch gh-pages at 2024-10-28 17:24 UTC

@codecov
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (d1e14a0) to head (b7d46ae).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33807      +/-   ##
=================================================
- Coverage          75.08%   74.96%   -0.13%     
=================================================
  Files                493      481      -12     
  Lines              21834    21044     -790     
  Branches            5458     5339     -119     
=================================================
- Hits               16395    15776     -619     
+ Misses              4792     4636     -156     
+ Partials             647      632      -15     
Flag Coverage Δ
unit 74.96% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim added this to the 7.1.0 milestone Oct 28, 2024
@ricardogarim ricardogarim marked this pull request as ready for review October 28, 2024 11:51
@ricardogarim ricardogarim requested review from a team as code owners October 28, 2024 11:51
@ricardogarim ricardogarim changed the base branch from develop to release-7.0.0 October 28, 2024 14:51
@ricardogarim ricardogarim requested review from a team as code owners October 28, 2024 14:51
@ricardogarim ricardogarim modified the milestones: 7.1.0, 7.0 Oct 28, 2024
@ricardogarim ricardogarim force-pushed the chore/dm-messages-query-param branch from 37e7c46 to d10bdb7 Compare October 28, 2024 14:53
@ricardogarim ricardogarim changed the title chore!: remove query field on dm messages listing regression: remove query field on dm messages listing Oct 28, 2024
@MarcosSpessatto MarcosSpessatto removed request for a team October 28, 2024 18:24
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Oct 28, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 28, 2024
@kodiakhq kodiakhq bot merged commit 2bc9692 into release-7.0.0 Oct 28, 2024
@kodiakhq kodiakhq bot deleted the chore/dm-messages-query-param branch October 28, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants