Skip to content

Comments

regression: Tracing times#33828

Merged
kodiakhq[bot] merged 3 commits intorelease-7.0.0from
fix/trace-times
Oct 30, 2024
Merged

regression: Tracing times#33828
kodiakhq[bot] merged 3 commits intorelease-7.0.0from
fix/trace-times

Conversation

@KevLehman
Copy link
Member

@KevLehman KevLehman commented Oct 29, 2024

Proposed changes (including videos or screenshots)

Before:
image

After:
image

Issue(s)

Steps to test or reproduce

Further comments

trace.end not taking promises into consideration and finishing spans earlier.

if makes no sens pls close, thx

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: e995029

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KevLehman KevLehman changed the title fix: Tracing times regression: Tracing times Oct 29, 2024
@KevLehman KevLehman added this to the 7.0 milestone Oct 29, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33828/
on branch gh-pages at 2024-10-30 17:38 UTC

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (1429d8f) to head (e995029).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33828   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review October 30, 2024 14:16
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is changing behavior when an exception is happening. it used to just log the exception for API requests with an error, but now it is giving an UnHandledPromiseRejection

@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Oct 30, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 30, 2024
@kodiakhq kodiakhq bot merged commit 9b600e1 into release-7.0.0 Oct 30, 2024
@kodiakhq kodiakhq bot deleted the fix/trace-times branch October 30, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants