Skip to content

Comments

regression: fix private apps upgrade buttons#33829

Merged
kodiakhq[bot] merged 1 commit intorelease-7.0.0from
marketplace_header_regression
Oct 29, 2024
Merged

regression: fix private apps upgrade buttons#33829
kodiakhq[bot] merged 1 commit intorelease-7.0.0from
marketplace_header_regression

Conversation

@MartinSchoeler
Copy link
Member

@MartinSchoeler MartinSchoeler commented Oct 29, 2024

Proposed changes (including videos or screenshots)

Restores a button to the header that was removed by accident on a rebase, also restores the icon to the other upgrade button

Issue(s)

PASLR-38

Steps to test or reproduce

On a community workspace (no premium) and no private apps installed:

  • Go to marketplace/private/
  • you should see a empty state with a upgrade button
  • the same button should exist on the empty state and the header

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 94b12ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler added this to the 7.0 milestone Oct 29, 2024
@github-actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33829/
on branch gh-pages at 2024-10-29 17:45 UTC

@codecov
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (69e1bee) to head (94b12ae).
Report is 3 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33829   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 29, 2024 18:55
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner October 29, 2024 18:55
@aleksandernsilva
Copy link
Contributor

@MartinSchoeler Could you please add a bit more context to this PR?
(Prints; Steps to reproduce; PR where the bug was originated)

Any one of these would help a lot.

@KevLehman
Copy link
Member

@MartinSchoeler Could you please add a bit more context to this PR? (Prints; Steps to reproduce; PR where the bug was originated)

Any one of these would help a lot.

And tests, dont forget the tests

@barbarazanellaa barbarazanellaa added the stat: QA assured Means it has been tested and approved by a company insider label Oct 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 29, 2024
@kodiakhq kodiakhq bot merged commit 4a5ab22 into release-7.0.0 Oct 29, 2024
@kodiakhq kodiakhq bot deleted the marketplace_header_regression branch October 29, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants