Skip to content

Comments

regression: thread unread count#33837

Merged
kodiakhq[bot] merged 1 commit intorelease-7.0.0from
regression/thread_unread
Oct 30, 2024
Merged

regression: thread unread count#33837
kodiakhq[bot] merged 1 commit intorelease-7.0.0from
regression/thread_unread

Conversation

@hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

regression originated from this PR: #33026

The thread followers was being called before updating the replies, causing the thread unread counter to do not update on the first reply

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/CORE-785

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: cbb5e6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (180a446) to head (cbb5e6a).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33837   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33837/
on branch gh-pages at 2024-10-30 15:14 UTC

@hugocostadev hugocostadev marked this pull request as ready for review October 30, 2024 16:05
@hugocostadev hugocostadev added this to the 7.0 milestone Oct 30, 2024
@casalsgh casalsgh added the stat: QA assured Means it has been tested and approved by a company insider label Oct 30, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 30, 2024
@kodiakhq kodiakhq bot merged commit c4b6006 into release-7.0.0 Oct 30, 2024
@kodiakhq kodiakhq bot deleted the regression/thread_unread branch October 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants