Skip to content

Comments

regression: Minimongo queries with operator matching only first found _id#33848

Merged
ggazzo merged 2 commits intorelease-7.0.0from
fix/minimongoRemove
Oct 31, 2024
Merged

regression: Minimongo queries with operator matching only first found _id#33848
ggazzo merged 2 commits intorelease-7.0.0from
fix/minimongoRemove

Conversation

@gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Oct 31, 2024

Proposed changes (including videos or screenshots)

There is an issue in the latest mongo release that broke some minimongo queries. When removing or updating multiple local records with a query that matches using operators ($in, $eq, etc) it would match only the first record and then bailout.

This was noticed because the bulkMessageDelete stream would not remove all messages provided in the query.

Issue(s)

CORE-786

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested review from a team as code owners October 31, 2024 14:36
@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 31, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2024

⚠️ No Changeset found

Latest commit: bd0dca2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gabriellsh gabriellsh changed the base branch from develop to release-7.0.0 October 31, 2024 14:36
@gabriellsh gabriellsh added this to the 7.0 milestone Oct 31, 2024
@github-actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33848/
on branch gh-pages at 2024-10-31 14:49 UTC

@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (d7aa8eb) to head (bd0dca2).
Report is 4 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33848   +/-   ##
==============================================
  Coverage          74.96%   74.96%           
==============================================
  Files                481      481           
  Lines              21044    21044           
  Branches            5339     5339           
==============================================
  Hits               15776    15776           
  Misses              4636     4636           
  Partials             632      632           
Flag Coverage Δ
unit 74.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabriellsh gabriellsh dismissed MarcosSpessatto’s stale review October 31, 2024 17:03

resolved in comments

@ggazzo ggazzo merged commit 95139ac into release-7.0.0 Oct 31, 2024
@ggazzo ggazzo deleted the fix/minimongoRemove branch October 31, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants