Skip to content

fix: EmojiPicker not displaying active category properly#35127

Merged
kodiakhq[bot] merged 6 commits intodevelopfrom
fix/emojiPicker-active-category
Feb 10, 2025
Merged

fix: EmojiPicker not displaying active category properly#35127
kodiakhq[bot] merged 6 commits intodevelopfrom
fix/emojiPicker-active-category

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Feb 5, 2025

Proposed changes (including videos or screenshots)

Possibly introduced when we upgraded virtuoso

Kapture 2025-02-06 at 16 58 52

Issue(s)

Steps to test or reproduce

Further comments

CORE-976

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Feb 5, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris added this to the 7.4.0 milestone Feb 5, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35127/

Built to branch gh-pages at 2025-02-05 17:01 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.20%. Comparing base (0a99a40) to head (d12a921).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #35127      +/-   ##
===========================================
- Coverage    59.20%   59.20%   -0.01%     
===========================================
  Files         2823     2823              
  Lines        67972    67960      -12     
  Branches     15120    15117       -3     
===========================================
- Hits         40245    40237       -8     
+ Misses       24900    24897       -3     
+ Partials      2827     2826       -1     
Flag Coverage Δ
unit 75.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: d12a921

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris force-pushed the fix/emojiPicker-active-category branch from c627cce to 20c5b68 Compare February 6, 2025 19:55
@dougfabris dougfabris marked this pull request as ready for review February 6, 2025 19:55
@dougfabris dougfabris requested a review from a team as a code owner February 6, 2025 19:55
@dougfabris dougfabris force-pushed the fix/emojiPicker-active-category branch from d4488b0 to 8b93b03 Compare February 7, 2025 14:13
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Feb 10, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 10, 2025
@kodiakhq kodiakhq bot merged commit 5473e35 into develop Feb 10, 2025
@kodiakhq kodiakhq bot deleted the fix/emojiPicker-active-category branch February 10, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants