fix: VoIP calls one-way audio issues#35420
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: eacf1ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35420 +/- ##
===========================================
+ Coverage 59.64% 59.67% +0.03%
===========================================
Files 2827 2828 +1
Lines 68477 68730 +253
Branches 15178 15225 +47
===========================================
+ Hits 40840 41016 +176
- Misses 24989 25055 +66
- Partials 2648 2659 +11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
tassoevan
requested changes
Mar 11, 2025
aleksandernsilva
approved these changes
Mar 12, 2025
aleksandernsilva
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
tassoevan
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
CORE-1026
Steps to test or reproduce
Further comments
To prevent react from destroying the audio element that is playing a call's audio, a workaround was made to pass this element as reference to the voip client, but in some situations the element was not passed at all and the voipclient had nothing to play the audio on.
I've changed the VoIPProvider to replace the ref with a callback which automatically updates the element whenever it is available.