Skip to content

Comments

refactor: move try to protect api.authenticatedRoute#36232

Closed
MarcosSpessatto wants to merge 5 commits intodevelopfrom
chore/catch-authenticate-route
Closed

refactor: move try to protect api.authenticatedRoute#36232
MarcosSpessatto wants to merge 5 commits intodevelopfrom
chore/catch-authenticate-route

Conversation

@MarcosSpessatto
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto commented Jun 17, 2025

This prevents an internal server error if any error happens on api.authenticatedRoute

https://rocketchat.atlassian.net/browse/ARCH-1654

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jun 17, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2025

⚠️ No Changeset found

Latest commit: 57c4eec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2025

PR Preview Action v1.6.1

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36232/

Built to branch gh-pages at 2025-06-18 17:58 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.38%. Comparing base (97b0496) to head (f0f9463).
Report is 9 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36232      +/-   ##
===========================================
+ Coverage    64.35%   64.38%   +0.02%     
===========================================
  Files         3139     3145       +6     
  Lines       104665   105136     +471     
  Branches     19763    19866     +103     
===========================================
+ Hits         67359    67687     +328     
- Misses       34620    34763     +143     
  Partials      2686     2686              
Flag Coverage Δ
unit 68.84% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review June 17, 2025 12:28
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner June 17, 2025 12:28
@ggazzo ggazzo added this to the 7.8.0 milestone Jun 17, 2025
@ggazzo ggazzo requested a review from a team as a code owner June 18, 2025 17:46
@ggazzo ggazzo force-pushed the chore/catch-authenticate-route branch from 4df6147 to f0f9463 Compare June 18, 2025 18:04
@ggazzo ggazzo force-pushed the chore/catch-authenticate-route branch from f0f9463 to 57c4eec Compare June 18, 2025 19:13
@ggazzo ggazzo requested a review from a team as a code owner June 18, 2025 19:13
@MarcosSpessatto MarcosSpessatto modified the milestones: 7.8.0, 7.9.0 Jun 23, 2025
@MarcosSpessatto MarcosSpessatto modified the milestones: 7.9.0, 7.10.0 Jul 24, 2025
@ggazzo ggazzo modified the milestones: 7.10.0, 7.11.0 Aug 27, 2025
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ggazzo
❌ Marcos Defendi


Marcos Defendi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dougfabris dougfabris modified the milestones: 7.11.0, 7.12.0 Sep 29, 2025
@dougfabris dougfabris modified the milestones: 7.12.0, 7.13.0 Oct 18, 2025
@dougfabris dougfabris removed this from the 7.13.0 milestone Jan 19, 2026
@dougfabris
Copy link
Member

@ggazzo is this still relevant?

@ggazzo
Copy link
Member

ggazzo commented Jan 26, 2026

@ggazzo is this still relevant?

yes, it is, although I suspect that it is no longer through this code that we will solve it, I am fighting against our old monsters in this pr, feel free to look and help us:

#38017

@ggazzo ggazzo closed this Jan 26, 2026
@ggazzo ggazzo deleted the chore/catch-authenticate-route branch January 26, 2026 12:27
@dougfabris
Copy link
Member

I'd love to but I do not have the proper jutsu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants