refactor: move try to protect api.authenticatedRoute#36232
refactor: move try to protect api.authenticatedRoute#36232MarcosSpessatto wants to merge 5 commits intodevelopfrom
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #36232 +/- ##
===========================================
+ Coverage 64.35% 64.38% +0.02%
===========================================
Files 3139 3145 +6
Lines 104665 105136 +471
Branches 19763 19866 +103
===========================================
+ Hits 67359 67687 +328
- Misses 34620 34763 +143
Partials 2686 2686
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4df6147 to
f0f9463
Compare
f0f9463 to
57c4eec
Compare
|
Marcos Defendi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@ggazzo is this still relevant? |
|
I'd love to but I do not have the proper jutsu |
This prevents an internal server error if any error happens on api.authenticatedRoute
https://rocketchat.atlassian.net/browse/ARCH-1654
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments