fix: prevent unhandled promise rejection if app has compiler error on startup#36802
Merged
fix: prevent unhandled promise rejection if app has compiler error on startup#36802
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 85dcd23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36802 +/- ##
===========================================
- Coverage 66.12% 66.11% -0.01%
===========================================
Files 3302 3302
Lines 110951 110951
Branches 21044 21042 -2
===========================================
- Hits 73364 73359 -5
- Misses 34916 34918 +2
- Partials 2671 2674 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ggazzo
approved these changes
Aug 27, 2025
ggazzo
pushed a commit
that referenced
this pull request
Aug 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixes an unhandled promise rejection crash that would happen during server startup if any of the apps installed had a compile error.
Issue(s)
Steps to test or reproduce
Further comments
CORE-1255
This PR keeps the solution simple in order to be "backportable". A proper refactor is implemented in #36803