chore!: remove deprecated livechat:takeInquiry method

[juliajforesti]

ARCH-1879

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

• Breaking Changes
  • The deprecated livechat:takeInquiry method has been removed from the Livechat API.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 8d912f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages

Name	Type
@rocket.chat/meteor	Major
@rocket.chat/core-typings	Major
@rocket.chat/rest-typings	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/http-router	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-contexts	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/federation-matrix	Patch
@rocket.chat/license	Patch
@rocket.chat/media-calls	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/models	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/omni-core-ee	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-video-conf	Major
@rocket.chat/ui-voip	Major
@rocket.chat/instance-status	Patch
@rocket.chat/omni-core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This pull request removes the deprecated livechat:takeInquiry Meteor method. Changes include adding a changeset documenting the removal for a major release, deleting the method implementation file, and removing its import from the server index.

Changes

Cohort / File(s)	Summary
Changeset Documentation .changeset/wicked-yaks-join.md	Added changeset documenting the removal of the deprecated livechat:takeInquiry method for a major release.
Livechat Server Setup apps/meteor/app/livechat/server/index.ts	Removed import of takeInquiry method, eliminating the module load during server initialization.
Livechat Method Implementation apps/meteor/app/livechat/server/methods/takeInquiry.ts	Deleted file containing the complete server-side Meteor method registration, including deprecation logging, authentication checks, permission validation, and the method implementation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Straightforward removal of deprecated code with consistent deletion pattern across files
• No logic changes or complex refactoring required
• Changes follow a simple cleanup pattern (remove import, delete implementation file, document in changeset)

Possibly related PRs

• chore!: remove deprecated livechat:saveAgentInfo method #37393 — Removes additional deprecated Livechat server DDP methods in the same area.
• chore!: removes livechat:getAnalyticsChartData deprecated method #36925 — Removes other deprecated Livechat Meteor methods from the same server directory.
• chore: Adds deprecation warning on livechat:takeInquiry #36993 — Previously modified the livechat:takeInquiry handling by adding deprecation logic and redirecting to REST endpoint.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• ggazzo
• KevLehman
• dougfabris

Poem

🐰 A method deprecated, now takes its final bow,
No more takeInquiry cluttering the plow,
Cleaned from the codebase with changeset in tow,
The old hops away, making room for the new to grow! ✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore!: remove deprecated livechat:takeInquiry method' directly and clearly summarizes the main change: removal of the deprecated livechat:takeInquiry method, which is evident from the changeset.
Linked Issues check	✅ Passed	The PR removes the deprecated livechat:takeInquiry method as required by ARCH-1879, including the method registration, interface declaration, and related imports.
Out of Scope Changes check	✅ Passed	All changes are in scope: the removal of takeInquiry import from index.ts, deletion of the takeInquiry.ts method file, and the changeset documenting this removal directly align with the stated objective.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/remove-takeInquiry

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 750af59 and 8d912f1.

📒 Files selected for processing (3)

• .changeset/wicked-yaks-join.md (1 hunks)
• apps/meteor/app/livechat/server/index.ts (0 hunks)
• apps/meteor/app/livechat/server/methods/takeInquiry.ts (0 hunks)

💤 Files with no reviewable changes (2)

• apps/meteor/app/livechat/server/index.ts
• apps/meteor/app/livechat/server/methods/takeInquiry.ts

🧰 Additional context used

🧠 Learnings (1)

📚 Learning: 2025-09-19T15:15:04.642Z

Learnt from: rodrigok
Repo: RocketChat/Rocket.Chat PR: 36991
File: apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts:219-221
Timestamp: 2025-09-19T15:15:04.642Z
Learning: The Federation_Matrix_homeserver_domain setting in apps/meteor/server/services/federation/infrastructure/rocket-chat/adapters/Settings.ts is part of the old federation system and is being deprecated/removed, so configuration issues with this setting should not be flagged for improvement.

Applied to files:

• .changeset/wicked-yaks-join.md

🔇 Additional comments (1)

.changeset/wicked-yaks-join.md (1)

1-5: ✓ Changeset format and content look good.

The changeset correctly documents the removal of the deprecated livechat:takeInquiry method with:

• Proper YAML frontmatter with package name and major version bump (appropriate for a breaking change)
• Clear, concise description of the removal
• Alignment with the deletion of the method implementation and removal of its import

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.93%. Comparing base (750af59) to head (8d912f1).
⚠️ Report is 3 commits behind head on release-8.0.0.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.0.0   #37464      +/-   ##
=================================================
+ Coverage          68.44%   70.93%   +2.48%     
=================================================
  Files               2877     3035     +158     
  Lines             101867   104621    +2754     
  Branches           17812    18439     +627     
=================================================
+ Hits               69727    74213    +4486     
+ Misses             30493    28455    -2038     
- Partials            1647     1953     +306     

Flag	Coverage Δ
e2e	58.04% <ø> (+9.15%)	⬆️
unit	72.29% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.