chore(federation): update typings to match EventEmitter property pruning#37570
chore(federation): update typings to match EventEmitter property pruning#37570
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughThe changes standardize event payload handling in federation-matrix event handlers by converting the room name handler to destructure event objects instead of flat payloads, and updating the message content type alias to reference the nested event structure. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37570 +/- ##
===========================================
- Coverage 68.94% 68.92% -0.02%
===========================================
Files 3360 3360
Lines 114282 114277 -5
Branches 20562 20561 -1
===========================================
- Hits 78790 78765 -25
- Misses 33406 33425 +19
- Partials 2086 2087 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Fixes the two leftover typing mismatches from RocketChat/homeserver#299 to fully align with pruned event payloads.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.