feat: Add phone-question-mark icon to IconElement in ui-kit#37865
feat: Add phone-question-mark icon to IconElement in ui-kit#37865kodiakhq[bot] merged 6 commits intodevelopfrom
phone-question-mark icon to IconElement in ui-kit#37865Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
WalkthroughThis change adds support for the 'phone-question-mark' icon by uncommenting it in the AvailableIcons type union. The infoCard story payloads are updated to demonstrate this new icon in both framed and non-framed variants, and one row's background is changed from default to secondary. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
packages/fuselage-ui-kit/src/stories/payloads/infoCard.ts(1 hunks)packages/ui-kit/src/blocks/elements/IconElement.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
packages/ui-kit/src/blocks/elements/IconElement.tspackages/fuselage-ui-kit/src/stories/payloads/infoCard.ts
🧠 Learnings (1)
📚 Learning: 2025-11-17T15:07:13.273Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37398
File: packages/fuselage-ui-kit/src/surfaces/FuselageSurfaceRenderer.tsx:357-363
Timestamp: 2025-11-17T15:07:13.273Z
Learning: In packages/fuselage-ui-kit/src/surfaces/FuselageSurfaceRenderer.tsx, IconElement is a presentational, non-actionable element that does not require wrapping in AppIdProvider, similar to plain_text and mrkdwn renderers. Only actionable elements (those with actions, actionId, or interactive behavior) should be wrapped in AppIdProvider.
Applied to files:
packages/ui-kit/src/blocks/elements/IconElement.tspackages/fuselage-ui-kit/src/stories/payloads/infoCard.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: CodeQL-Build
🔇 Additional comments (2)
packages/fuselage-ui-kit/src/stories/payloads/infoCard.ts (2)
58-58: LGTM! New icon usage is consistent.The
phone-question-markicon is properly demonstrated in both framed (line 58) and non-framed (line 68) variants with appropriate variant styling. This aligns well with the updated type definition.Also applies to: 68-68
63-63: Background changed to 'secondary'.The background color was changed from
'default'to'secondary'for the non-framed icons row. This appears intentional to provide visual contrast for demonstration purposes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37865 +/- ##
===========================================
+ Coverage 67.68% 67.70% +0.01%
===========================================
Files 3474 3474
Lines 113852 113852
Branches 20938 20938
===========================================
+ Hits 77065 77084 +19
+ Misses 34604 34585 -19
Partials 2183 2183
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Issue(s)
VGA-118
Steps to test or reproduce
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.