Skip to content

chore: undeprecate /v1/e2e.updateGroupKey endpoint#37894

Merged
ggazzo merged 1 commit intodevelopfrom
fix/undeprecate-e2e.updateGroupKey
Dec 19, 2025
Merged

chore: undeprecate /v1/e2e.updateGroupKey endpoint#37894
ggazzo merged 1 commit intodevelopfrom
fix/undeprecate-e2e.updateGroupKey

Conversation

@cardoso
Copy link
Copy Markdown
Member

@cardoso cardoso commented Dec 19, 2025

Proposed changes (including videos or screenshots)

This endpoint was deprecated in #32197 , however its usage was reintroduced in #33328 . It seems the best path forward is to undeprecate it.

Issue(s)

https://rocketchat.atlassian.net/browse/ARCH-1741

Steps to test or reproduce

Further comments

Summary by CodeRabbit

  • Bug Fixes
    • Removed the deprecation marking for the e2e.updateGroupKey API endpoint, ensuring it remains available; existing authentication, validation, and behavior are unchanged.

✏️ Tip: You can customize this high-level summary in your review settings.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Dec 19, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Dec 19, 2025

⚠️ No Changeset found

Latest commit: 7c8db5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Dec 19, 2025

Walkthrough

Removed the deprecation metadata from the e2e.updateGroupKey API route in v1; the route no longer contains a deprecation block. Authentication, validation, and handler configuration are unchanged.

Changes

Cohort / File(s) Summary
E2E API Route Configuration
apps/meteor/app/api/server/v1/e2e.ts
Removed deprecation: { version: '8.0.0' } metadata from the e2e.updateGroupKey route definition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single-file change removing a metadata block
  • No behavioral, control-flow, or validation changes
  • Files to spot-check: apps/meteor/app/api/server/v1/e2e.ts for route integrity and any docs referencing the deprecation

Poem

🐰 I nudged a flag from deprecated hay,
e2e.updateGroupKey hops back to play.
No logic changed, just a label freed,
A tiny bounce for an endpoint in need. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing deprecation from the e2e.updateGroupKey endpoint.
Linked Issues check ✅ Passed The PR successfully addresses ARCH-1741 by removing the deprecation metadata from the e2e.updateGroupKey endpoint as required.
Out of Scope Changes check ✅ Passed All changes in the PR are directly related to undeprecating the e2e.updateGroupKey endpoint; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/undeprecate-e2e.updateGroupKey

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 92ff409 and 7c8db5b.

📒 Files selected for processing (1)
  • apps/meteor/app/api/server/v1/e2e.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/meteor/app/api/server/v1/e2e.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 19, 2025

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 358MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB -242B
queue-worker-service 132MiB 132MiB +1.3KiB
ddp-streamer-service 126MiB 126MiB +1.3KiB
account-service 113MiB 113MiB +830B
authorization-service 111MiB 111MiB +2.3KiB
stream-hub-service 111MiB 111MiB +913B
presence-service 111MiB 111MiB +302B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 19:59", "12/19 20:04 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
Loading

Statistics (last 25 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37894
  • Baseline: develop
  • Timestamp: 2025-12-19 20:04:18 UTC
  • Historical data points: 25

Updated: Fri, 19 Dec 2025 20:04:18 GMT

@cardoso cardoso changed the title fix(e2e): undeprecate updateGroupKey endpoint fix: undeprecate /v1/e2e.updateGroupKey endpoint Dec 19, 2025
@cardoso cardoso force-pushed the fix/undeprecate-e2e.updateGroupKey branch from a048fbc to 92ff409 Compare December 19, 2025 18:16
@ggazzo ggazzo changed the title fix: undeprecate /v1/e2e.updateGroupKey endpoint chore: undeprecate /v1/e2e.updateGroupKey endpoint Dec 19, 2025
@cardoso cardoso marked this pull request as ready for review December 19, 2025 18:32
@cardoso cardoso requested a review from a team as a code owner December 19, 2025 18:32
@cardoso cardoso added this to the 7.14.0 milestone Dec 19, 2025
@cardoso cardoso force-pushed the fix/undeprecate-e2e.updateGroupKey branch from 92ff409 to 7c8db5b Compare December 19, 2025 19:23
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Dec 19, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 19, 2025
@ggazzo ggazzo merged commit 5f160c4 into develop Dec 19, 2025
49 checks passed
@ggazzo ggazzo deleted the fix/undeprecate-e2e.updateGroupKey branch December 19, 2025 20:12
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.71%. Comparing base (cc3a99f) to head (7c8db5b).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37894      +/-   ##
===========================================
- Coverage    67.71%   67.71%   -0.01%     
===========================================
  Files         3475     3475              
  Lines       113861   113861              
  Branches     20942    20942              
===========================================
- Hits         77103    77097       -6     
- Misses       34575    34582       +7     
+ Partials      2183     2182       -1     
Flag Coverage Δ
e2e 57.19% <ø> (-0.03%) ⬇️
e2e-api 44.06% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gaolin1 pushed a commit to gaolin1/medsense.webchat that referenced this pull request Jan 6, 2026
@dougfabris dougfabris modified the milestones: 7.14.0, 8.0.0 Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants