chore(deps): remove unused bytebuffer#38199
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
WalkthroughThe pull request removes the "bytebuffer" runtime dependency and its type definitions ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38199 +/- ##
========================================
Coverage 70.71% 70.72%
========================================
Files 3147 3147
Lines 108851 108851
Branches 19592 19615 +23
========================================
+ Hits 76977 76985 +8
+ Misses 29877 29862 -15
- Partials 1997 2004 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
53883e7 to
e61cd4c
Compare
Proposed changes (including videos or screenshots)
This dependency became unused after #36942 , being replaced by a couple dozen lines of code compared to the 1mb+ for
bytebufferand the transitivelongdependency.Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.