chore: remove left over oplog code#38313
Merged
kodiakhq[bot] merged 4 commits intodevelopfrom Feb 9, 2026
Merged
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Contributor
WalkthroughRemoves oplog-based observer recovery and metrics, disables oplog unconditionally, and introduces a token-driven reactivity system that monkey-patches observeChanges to manage per-user token callbacks and session invalidation. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client Observer
participant Connection as Connection._observeChanges
participant UserReactivity as userReactivity
participant Mongo as Mongo Users Collection
participant Service as Meteor Service
Client->>Connection: start observeChanges(users, fields:{tokens})
Connection->>UserReactivity: delegate observe hook
UserReactivity->>Mongo: initial fetch matching records
Mongo-->>UserReactivity: return records
UserReactivity->>UserReactivity: store per-user hashed-token callbacks
UserReactivity-->>Client: emit added/ready events
Service->>UserReactivity: processOnChange(diff, userId)
UserReactivity->>UserReactivity: detect removed tokens for userId
UserReactivity-->>Client: emit removed callbacks (session invalidation)
Client->>Service: client handles invalidation
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested Labels
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #38313 +/- ##
===========================================
- Coverage 70.39% 70.39% -0.01%
===========================================
Files 3161 3162 +1
Lines 110654 110650 -4
Branches 19892 19920 +28
===========================================
- Hits 77895 77889 -6
- Misses 30731 30735 +4
+ Partials 2028 2026 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
📦 Docker Image Size Report➡️ Changes
📊 Historical Trend---
config:
theme: "dark"
xyChart:
width: 900
height: 400
---
xychart
title "Image Size Evolution by Service (Last 30 Days + This PR)"
x-axis ["11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/09 13:07 (PR)"]
y-axis "Size (GB)" 0 --> 0.5
line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.00]
line "omnichannel-transcript-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
line "queue-worker-service" [0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
line "rocketchat" [0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.00]
Statistics (last 30 days):
ℹ️ About this reportThis report compares Docker image sizes from this build against the
Updated: Mon, 09 Feb 2026 13:07:27 GMT |
sampaiodiego
changed the title
sampaiodiego
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@apps/meteor/server/services/meteor/userReactivity.ts`:
- Around line 17-72: The override
MongoInternals.Connection.prototype._observeChanges must be synchronous and
return a handle immediately (not an async function); change the async function
to a normal function that starts the initial DB query asynchronously,
immediately returns an object with stop(), isReady (initially false) and
isReadyPromise (a Promise resolved when the initial query completes), and when
the async query finishes set isReady=true and resolve isReadyPromise and invoke
callbacks.added as currently implemented; also forward additional query options
(e.g., sort, limit, skip, hint, etc.) from the options param when calling
mongo.rawCollection(...).find(...) so you don't only pass projection/fields;
keep the userCallbacks and serviceConfigCallbacks logic but ensure stop() can
cancel/cleanup even if called before the initial query resolves.
🧹 Nitpick comments (3)
apps/meteor/packages/rocketchat-mongo-config/server/index.js (1)
7-8: Drop the inline comment to match repo guidance.
The assignment is self-explanatory; keep the rationale out of the implementation.As per coding guidelines, Avoid code comments in the implementation.🧹 Suggested change
-// we always want Meteor to disable oplog tailing Package['disable-oplog'] = {};apps/meteor/server/services/meteor/userReactivity.ts (2)
11-16: Remove inline comments and the commented-out debug line.
These are implementation notes; keep code comment-free per repo guidance.As per coding guidelines, Avoid code comments in the implementation.🧹 Suggested change
-// Stores the callbacks for the disconnection reactivity bellow const userCallbacks = new Map(); -// Overrides the native observe changes to prevent database polling and stores the callbacks -// for the users' tokens to re-implement the reactivity based on our database listeners const { mongo } = MongoInternals.defaultRemoteCollectionDriver(); @@ - // console.error('Connection.Collection.prototype._observeChanges', collectionName, selector, options); @@ -// Re-implement meteor's reactivity that uses observe to disconnect sessions when the token -// associated was removed export const processOnChange = (diff: Record<string, any>, id: string): void => {Also applies to: 33-33, 74-76
83-90: Clean up empty per-user callback sets.
After removals, empty sets remain inuserCallbacks; deleting them avoids unnecessary retention.🧹 Suggested change
if (cbs) { [...cbs] .filter(({ hashedToken }) => tokens === undefined || !tokens.includes(hashedToken)) .forEach((item) => { item.callbacks.removed(id); cbs.delete(item); }); + if (cbs.size === 0) { + userCallbacks.delete(id); + } }
KevLehman
reviewed
Jan 29, 2026
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
KevLehman
approved these changes
Jan 29, 2026
ggazzo
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.