chore: normalize urls extraction for messages

[Copilot]

URL parsing for link previews was called externally in sendMessage and updateMessage functions. This moves the parseUrlsInMessage call into Message.beforeSave to consolidate message preparation logic.
https://rocketchat.atlassian.net/browse/ARCH-1970

Changes

• IMessageService interface: Added optional previewUrls parameter to beforeSave method signature
• MessageService.beforeSave: Now calls parseUrlsInMessage(message, previewUrls) internally after markdown parsing
• sendMessage.ts & updateMessage.ts: Removed direct parseUrlsInMessage calls, now pass previewUrls to beforeSave

Example

Before:

parseUrlsInMessage(message, previewUrls);
message = await Message.beforeSave({ message, room, user });

After:

message = await Message.beforeSave({ message, room, user, previewUrls });

All message processing now flows through a single lifecycle point. Existing callers without previewUrls continue to work unchanged.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: e5a3f47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ggazzo]

/jira ARCH-1935

[cubic-dev-ai]

2 issues found across 5 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/meteor/app/lib/server/functions/extractUrlsFromMessageAST.ts">

<violation number="1" location="apps/meteor/app/lib/server/functions/extractUrlsFromMessageAST.ts:23">
P2: Protocol-relative URLs from LINK nodes are pushed without normalization, but tests expect `//` links to be converted to `https://`. Normalize before pushing so schema-less links generate previews correctly.</violation>
</file>

<file name="apps/meteor/app/lib/server/functions/parseUrlsInMessage.ts">

<violation number="1" location="apps/meteor/app/lib/server/functions/parseUrlsInMessage.ts:32">
P2: This conditional skips clearing message.urls when no URLs are found, leaving stale URLs on edits that remove links. Assign message.urls even for an empty list so old previews are cleared.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.55%. Comparing base (260e9af) to head (e5a3f47).
⚠️ Report is 22 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #38795      +/-   ##
===========================================
- Coverage    70.58%   70.55%   -0.03%     
===========================================
  Files         3182     3182              
  Lines       112442   112483      +41     
  Branches     20378    20376       -2     
===========================================
- Hits         79365    79361       -4     
- Misses       31025    31071      +46     
+ Partials      2052     2051       -1     

Flag	Coverage Δ
e2e	60.39% <100.00%> (+<0.01%)	⬆️
e2e-api	48.85% <100.00%> (-0.02%)	⬇️
unit	71.47% <100.00%> (-0.06%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change	Percent
sum of all images	1.1GiB	1.1GiB	+11MiB
rocketchat	360MiB	349MiB	+11MiB
omnichannel-transcript-service	134MiB	134MiB	-1.8KiB
queue-worker-service	134MiB	134MiB	-302B
ddp-streamer-service	128MiB	128MiB	-2.3KiB
account-service	115MiB	115MiB	+409B
authorization-service	112MiB	112MiB	-676B
presence-service	112MiB	112MiB	-362B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/12 22:57", "02/13 22:38", "02/16 14:04", "02/18 23:15", "02/19 23:23", "02/20 03:13", "02/20 04:00 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]

Loading

Statistics (last 30 days):

• 📊 Average: 1.5GiB
• ⬇️ Minimum: 1.4GiB
• ⬆️ Maximum: 1.6GiB
• 🎯 Current PR: 1.1GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

• Tag: pr-38795
• Baseline: develop
• Timestamp: 2026-02-20 04:00:43 UTC
• Historical data points: 30

---

Updated: Fri, 20 Feb 2026 04:00:43 GMT

[cubic-dev-ai]

2 issues found across 5 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/meteor/server/services/messages/hooks/BeforeSaveJumpToMessage.ts">

<violation number="1" location="apps/meteor/server/services/messages/hooks/BeforeSaveJumpToMessage.ts:141">
P2: Remove debug console logging from this server-side hook to avoid leaking message data and adding noisy logs in production.

(Based on your team's feedback about avoiding console statements in production code.) [FEEDBACK_USED]</violation>
</file>

<file name="apps/meteor/server/services/messages/service.ts">

<violation number="1" location="apps/meteor/server/services/messages/service.ts:239">
P2: Unconditionally assigning `message.urls` breaks the `parseUrls=false` behavior by adding an empty `urls` property. Keep `urls` unset when `parseUrls` is explicitly false.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/meteor/app/lib/server/functions/parseUrlsInMessage.ts">

<violation number="1" location="apps/meteor/app/lib/server/functions/parseUrlsInMessage.ts:16">
P2: `parseUrlsInMessage` no longer honors `message.parseUrls === false`, so callers that explicitly disable URL parsing (e.g., webhook payloads with attachments) will still have URLs extracted. This is a behavioral regression; add the guard back so `parseUrls` is respected.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/meteor/server/services/messages/service.ts">

<violation number="1" location="apps/meteor/server/services/messages/service.ts:239">
P2: The `parseUrls` flag is no longer honored. `message.urls` is now set even when callers explicitly send `parseUrls: false`, which breaks the documented API behavior and existing tests expecting no `urls` field.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[ggazzo]

@sampaiodiego fyi