fix: resolve memory leak in useReconnectCountdown hook#38841
Merged
ggazzo merged 1 commit intoRocketChat:developfrom Feb 20, 2026
Merged
fix: resolve memory leak in useReconnectCountdown hook#38841ggazzo merged 1 commit intoRocketChat:developfrom
ggazzo merged 1 commit intoRocketChat:developfrom
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Member
|
/jira ARCH-1935 |
ggazzo
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR resolves a memory leak in
apps/meteor/client/components/connectionStatus/useReconnectCountdown.ts.The Issue:
The
setIntervalused to manage the reconnect countdown timer was not being properly cleared when the component unmounted. Because the interval ID was stored in auseRef(reconnectionTimerRef.current), if the component unmounted while the status was'waiting', the timer would continue running orphaned in the background.The Fix:
useEffecthook.reconnectionTimerRef.current.undefinedto ensure a clean state initialization on subsequent renders.Issue(s)
Found via static analysis auditing for unhandled subscription/listener cleanups. (No existing issue number).
Steps to test or reproduce
useReconnectCountdowncomponent mounts and status becomes'waiting'.Further comments
The fix defensively checks for the existence of
reconnectionTimerRef.currentbefore callingclearIntervaland resets the reference, ensuring no stale closures or ghost intervals persist.Task: ARCH-1978