Fix bug when setting readonly room as default room#4422
Merged
engelgabriel merged 4 commits intoRocketChat:developfrom Sep 29, 2016
Merged
Fix bug when setting readonly room as default room#4422engelgabriel merged 4 commits intoRocketChat:developfrom
engelgabriel merged 4 commits intoRocketChat:developfrom
Conversation
Contributor
Author
|
Any ideas why the build keeps on failing when building Just logs Seems to be doing it in general (nothing to do with these code changes) |
Contributor
|
@alexbrazier I haven't tested it out, but what does the chat box to type in look like when you're muted? I think it'd be nice if the chat box became disabled and the placeholder/text in it became "Chatting disabled, you have been muted." and the user couldn't type of click any of the buttons to do any actions. @engelgabriel any idea why the build is failing in travis? |
Contributor
Author
|
Seems the build is now passing. |
rodrigok
approved these changes
Sep 29, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@RocketChat/core
Closes #4405
Probably also closes #825 as this is now done